Move current... methods to Phases and Periods

Author: odersky

compiler/src/dotty/tools/dotc/Run.scala

@@ -10,7 +10,7 @@ import Scopes._
 import typer.{ImportInfo, Typer}
 import Decorators._
 import io.{AbstractFile, PlainFile}
-import Phases.curPhases
+import Phases.{curPhases, currentPhase}
 
 import scala.io.Codec
 import util.{Set => _, _}

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -13,6 +13,7 @@ import Decorators.{given _}, DenotTransformers._
 import collection.{immutable, mutable}
 import util.{Property, SourceFile, NoSource}
 import NameKinds.{TempResultName, OuterSelectName}
+import Phases.currentPhase
 import typer.ConstFold
 
 import scala.annotation.tailrec

compiler/src/dotty/tools/dotc/core/Annotations.scala

@@ -7,6 +7,7 @@ import StdNames._
 import dotty.tools.dotc.ast.tpd
 import scala.util.Try
 import util.Spans.Span
+import Periods.currentRunId
 
 object Annotations {
 

compiler/src/dotty/tools/dotc/core/Contexts.scala

@@ -75,15 +75,6 @@ object Contexts {
   inline def atPhaseNotLaterThan[T](limit: Phase)(inline op: Context ?=> T)(using Context): T =
     op(using if !limit.exists || currentPhase <= limit then ctx else ctx.withPhase(limit))
 
-  inline def currentPeriod(using ctx: Context): Period = ctx.period
-
-  inline def currentPhase(using ctx: Context): Phase = ctx.base.phases(ctx.period.firstPhaseId)
-
-  inline def currentRunId(using ctx: Context): Int = ctx.period.runId
-
-  inline def currentPhaseId(using ctx: Context): Int = ctx.period.phaseId
-
-
   /** A context is passed basically everywhere in dotc.
    *  This is convenient but carries the risk of captured contexts in
    *  objects that turn into space leaks. To combat this risk, here are some

compiler/src/dotty/tools/dotc/core/Denotations.scala

@@ -15,6 +15,7 @@ import Flags._
 import DenotTransformers._
 import Decorators._
 import Signature.MatchDegree._
+import Phases.currentPhase
 import printing.Texts._
 import printing.Printer
 import io.AbstractFile
@@ -758,7 +759,7 @@ object Denotations {
      *  the symbol is stale, which constitutes an internal error.
      */
     def current(using Context): SingleDenotation = {
-      val currentPeriod = Contexts.currentPeriod
+      val now = Periods.currentPeriod
       val valid = myValidFor
       if (valid.code <= 0) {
         // can happen if we sit on a stale denotation which has been replaced
@@ -769,29 +770,29 @@ object Denotations {
         assert(false, this)
       }
 
-      if (valid.runId != currentPeriod.runId)
+      if (valid.runId != now.runId)
         if (exists) initial.bringForward().current
         else this
       else {
         var cur = this
-        if (currentPeriod.code > valid.code) {
+        if (now.code > valid.code) {
           // search for containing period as long as nextInRun increases.
           var next = nextInRun
-          while (next.validFor.code > valid.code && !(next.validFor contains currentPeriod)) {
+          while (next.validFor.code > valid.code && !(next.validFor contains now)) {
             cur = next
             next = next.nextInRun
           }
           if (next.validFor.code > valid.code) {
-            // in this case, next.validFor contains currentPeriod
+            // in this case, next.validFor contains now
             cur = next
             cur
           }
           else {
-            //println(s"might need new denot for $cur, valid for ${cur.validFor} at $currentPeriod")
+            //println(s"might need new denot for $cur, valid for ${cur.validFor} at $now")
             // not found, cur points to highest existing variant
             val nextTransformerId = ctx.base.nextDenotTransformerId(cur.validFor.lastPhaseId)
-            if (currentPeriod.lastPhaseId <= nextTransformerId)
-              cur.validFor = Period(currentPeriod.runId, cur.validFor.firstPhaseId, nextTransformerId)
+            if (now.lastPhaseId <= nextTransformerId)
+              cur.validFor = Period(now.runId, cur.validFor.firstPhaseId, nextTransformerId)
             else {
               var startPid = nextTransformerId + 1
               val transformer = ctx.base.denotTransformers(nextTransformerId)
@@ -814,19 +815,19 @@ object Denotations {
                 next.insertAfter(cur)
                 cur = next
               }
-              cur.validFor = Period(currentPeriod.runId, startPid, transformer.lastPhaseId)
+              cur.validFor = Period(now.runId, startPid, transformer.lastPhaseId)
               //printPeriods(cur)
               //println(s"new denot: $cur, valid for ${cur.validFor}")
             }
             cur.current // multiple transformations could be required
           }
         }
         else {
-          // currentPeriod < end of valid; in this case a version must exist
+          // now < end of valid; in this case a version must exist
           // but to be defensive we check for infinite loop anyway
           var cnt = 0
-          while (!(cur.validFor contains currentPeriod)) {
-            //println(s"searching: $cur at $currentPeriod, valid for ${cur.validFor}")
+          while (!(cur.validFor contains now)) {
+            //println(s"searching: $cur at $now, valid for ${cur.validFor}")
             cur = cur.nextInRun
             // Note: One might be tempted to add a `prev` field to get to the new denotation
             // more directly here. I tried that, but it degrades rather than improves

compiler/src/dotty/tools/dotc/core/Periods.scala

@@ -5,6 +5,12 @@ import Phases.curPhases
 
 object Periods {
 
+  inline def currentPeriod(using ctx: Context): Period = ctx.period
+
+  inline def currentRunId(using ctx: Context): RunId = ctx.period.runId
+
+  inline def currentPhaseId(using ctx: Context): PhaseId = ctx.period.phaseId
+
   /** The period containing the current period where denotations do not change.
    *  We compute this by taking as first phase the first phase less or equal to
    *  the current phase that has the same "nextTransformerId". As last phase

compiler/src/dotty/tools/dotc/core/Phases.scala

@@ -24,6 +24,8 @@ trait Phases {
 
 object Phases {
 
+  inline def currentPhase(using ctx: Context): Phase = ctx.base.phases(ctx.period.firstPhaseId)
+
   inline def phaseOf(id: PhaseId)(using Context): Phase =
     ctx.base.phases(id)
 

compiler/src/dotty/tools/dotc/core/Scopes.scala

@@ -15,6 +15,7 @@ import Contexts._
 import Phases._
 import Denotations._
 import SymDenotations._
+import Periods.currentPhaseId
 import printing.Texts._
 import printing.Printer
 import util.common._

compiler/src/dotty/tools/dotc/core/TypeOps.scala

@@ -10,6 +10,7 @@ import util.SourcePosition
 import NameKinds.DepParamName
 import Decorators._
 import StdNames._
+import Phases.currentPhase
 import collection.mutable
 import ast.tpd._
 import reporting.{trace, Message}

compiler/src/dotty/tools/dotc/reporting/Reporter.scala

@@ -8,6 +8,7 @@ import core.Contexts._
 import core.TypeError
 import util.{SourcePosition, NoSourcePosition}
 import core.Decorators.PhaseListDecorator
+import core.Phases.currentPhase
 import collection.mutable
 import core.Mode
 import dotty.tools.dotc.core.Symbols.{Symbol, NoSymbol}

compiler/src/dotty/tools/dotc/transform/SyntheticMembers.scala

@@ -7,6 +7,7 @@ import Flags._
 import DenotTransformers._
 import Decorators._
 import NameOps._
+import Phases.currentPhase
 import Annotations.Annotation
 import typer.ProtoTypes.constrained
 import ast.untpd

compiler/src/dotty/tools/dotc/transform/TransformByNameApply.scala

@@ -11,6 +11,7 @@ import Types._
 import Flags._
 import Decorators._
 import DenotTransformers._
+import Phases.currentPhase
 import core.StdNames.nme
 import ast.Trees._
 import reporting.trace

compiler/src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -13,6 +13,7 @@ import core.NameKinds.{DocArtifactName, OuterSelectName}
 import core.Decorators._
 import core.Phases._
 import core.Mode
+import core.Periods.currentPhaseId
 import typer._
 import typer.ErrorReporting._
 import reporting.ThrowingReporter

compiler/src/dotty/tools/dotc/transform/ValueClasses.scala

@@ -6,6 +6,7 @@ import Types._
 import Symbols._
 import Contexts._
 import Phases._
+import Periods.currentPhaseId
 import Flags._
 import StdNames._
 import SymUtils._

compiler/src/dotty/tools/dotc/transform/YCheckPositions.scala

@@ -6,7 +6,7 @@ import dotty.tools.dotc.ast.{tpd, untpd}
 import dotty.tools.dotc.core.Contexts._
 import dotty.tools.dotc.core.Decorators._
 import dotty.tools.dotc.core.Flags._
-import dotty.tools.dotc.core.Phases.{Phase, postTyperPhase}
+import dotty.tools.dotc.core.Phases.{Phase, postTyperPhase, currentPhase}
 import dotty.tools.dotc.core.Symbols._
 import dotty.tools.dotc.util.{SourceFile, SourcePosition}
 

compiler/src/dotty/tools/dotc/typer/Checking.scala

@@ -14,6 +14,7 @@ import Trees._
 import TreeInfo._
 import ProtoTypes._
 import Scopes._
+import Phases.currentPhase
 import CheckRealizable._
 import ErrorReporting.errorTree
 import rewrites.Rewrites.patch

compiler/src/dotty/tools/dotc/typer/ErrorReporting.scala

@@ -6,6 +6,7 @@ import ast._
 import core._
 import Types._, ProtoTypes._, Contexts._, Decorators._, Denotations._, Symbols._
 import Implicits._, Flags._, Constants.Constant
+import Phases.currentPhase
 import util.Spans._
 import util.SourcePosition
 import config.Feature

compiler/src/dotty/tools/dotc/typer/Implicits.scala

@@ -24,7 +24,7 @@ import Constants._
 import ProtoTypes._
 import ErrorReporting._
 import reporting.Message
-import Phases.currentlyAfterTyper
+import Phases.{currentPhase, currentlyAfterTyper}
 import Inferencing.{fullyDefinedType, isFullyDefined}
 import Trees._
 import transform.SymUtils._

compiler/src/dotty/tools/dotc/typer/Namer.scala

@@ -7,6 +7,7 @@ import ast._
 import Trees._, StdNames._, Scopes._, Denotations._, NamerOps._, ContextOps._
 import Contexts._, Symbols._, Types._, SymDenotations._, Names._, NameOps._, Flags._
 import Decorators.{given _}, Comments.{_, given _}
+import Periods.currentRunId
 import NameKinds.DefaultGetterName
 import TypeApplications.TypeParamInfo
 import ast.desugar, ast.desugar._

compiler/src/dotty/tools/dotc/typer/TypeAssigner.scala

@@ -6,6 +6,7 @@ import core._
 import ast._
 import Contexts._, Constants._, Types._, Symbols._, Names._, Flags._, Decorators._
 import ErrorReporting._, Annotations._, Denotations._, SymDenotations._, StdNames._
+import Phases.currentPhase
 import util.Spans._
 import util.SourcePosition
 import config.Printers.typr

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -25,7 +25,7 @@ import Decorators.{given _}
 import ErrorReporting._
 import Checking._
 import Inferencing._
-import Phases.currentlyAfterTyper
+import Phases.{currentPhase, currentlyAfterTyper}
 import EtaExpansion.etaExpand
 import util.Spans._
 import util.common._