Review CRs 3

Author: pikinier20

scaladoc/src/dotty/tools/scaladoc/snippets/SnippetCompiler.scala

@@ -21,7 +21,6 @@ import scala.util.{ Try, Success, Failure }
 
 class SnippetCompiler(
   val snippetCompilerSettings: Seq[SnippetCompilerSetting[_]],
-  val scalacOptions: String = "",
   target: AbstractFile = new VirtualDirectory("(memory)")
 ):
   object SnippetDriver extends Driver:
@@ -30,11 +29,10 @@ class SnippetCompiler(
       rootCtx.setSetting(rootCtx.settings.YretainTrees, true)
       rootCtx.setSetting(rootCtx.settings.YcookComments, true)
       rootCtx.setSetting(rootCtx.settings.YreadComments, true)
-      val defaultFlags =
-        List("-color:never", "-unchecked", "-deprecation", "-Ximport-suggestion-timeout", "0")
-      val options = scalacOptions.split("\\s+").toList
-      val settings = options ::: defaultFlags ::: Nil
-      val ctx = setup(settings.toArray, rootCtx) match
+      rootCtx.setSetting(rootCtx.settings.color, "never")
+      rootCtx.setSetting(rootCtx.settings.XimportSuggestionTimeout, 0)
+
+      val ctx = setup(Array(""), rootCtx) match
         case Some((_, ctx)) =>
           ctx
         case None => rootCtx

scaladoc/test/dotty/tools/scaladoc/snippets/SnippetCompilerTest.scala

@@ -6,7 +6,9 @@ import org.junit.Assert._
 import dotty.tools.io.{AbstractFile, VirtualDirectory}
 
 class SnippetCompilerTest {
-  val compiler = SnippetCompiler(Seq(), " -usejavacp")
+  val compiler = SnippetCompiler(
+    Seq(SnippetCompilerSetting(testContext.settings.usejavacp, true))
+  )
   def wrapFn: String => WrappedSnippet = (str: String) => WrappedSnippet(
     str,
     Some("test"),