Run all miniphases at group end

We now have all miniphases running at group end. We can remove the infrastructure
to enable other behavior. If some parts of some transformations need to run at a different
phase than group end, we can always to `ctx.atPhase { ... }`.

Author: odersky

compiler/src/dotty/tools/backend/jvm/CollectSuperCalls.scala

@@ -22,9 +22,6 @@ class CollectSuperCalls extends MiniPhaseTransform {
 
   def phaseName: String = "collectSuperCalls"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformSelect(tree: Select)(implicit ctx: Context, info: TransformerInfo): Tree = {
     tree.qualifier match {
       case sup: Super =>

compiler/src/dotty/tools/backend/jvm/LabelDefs.scala

@@ -88,9 +88,6 @@ class LabelDefs extends MiniPhaseTransform {
   val beingAppended = new mutable.HashSet[Symbol]()
   var labelLevel = 0
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformDefDef(tree: tpd.DefDef)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     if (tree.symbol is Flags.Label) tree
     else {

compiler/src/dotty/tools/dotc/transform/AugmentScala2Traits.scala

@@ -35,9 +35,6 @@ class AugmentScala2Traits extends MiniPhaseTransform with IdentityDenotTransform
 
   override def phaseName: String = "augmentScala2Traits"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def rewiredTarget(referenced: Symbol, derived: Symbol)(implicit ctx: Context) = NoSymbol
 
   override def transformTemplate(impl: Template)(implicit ctx: Context, info: TransformerInfo) = {

compiler/src/dotty/tools/dotc/transform/ByNameClosures.scala

@@ -29,9 +29,6 @@ class ByNameClosures extends TransformByNameApply with IdentityDenotTransformer
 
   override def phaseName: String = "byNameClosures"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def mkByNameClosure(arg: Tree, argType: Type)(implicit ctx: Context): Tree = {
     val meth = ctx.newSymbol(
       ctx.owner, nme.ANON_FUN, Synthetic | Method, MethodType(Nil, Nil, argType))

compiler/src/dotty/tools/dotc/transform/CheckReentrant.scala

@@ -45,9 +45,6 @@ class CheckReentrant extends MiniPhaseTransform { thisTransformer =>
 
   override def phaseName = "checkReentrant"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   private[this] var shared: Set[Symbol] = Set()
   private[this] var seen: Set[ClassSymbol] = Set()
   private[this] var indent: Int = 0

compiler/src/dotty/tools/dotc/transform/CheckStatic.scala

@@ -39,9 +39,6 @@ class CheckStatic extends MiniPhaseTransform { thisTransformer =>
 
   override def phaseName = "checkStatic"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformTemplate(tree: tpd.Template)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     val defns = tree.body.collect{case t: ValOrDefDef => t}
     var hadNonStaticField = false

compiler/src/dotty/tools/dotc/transform/ClassOf.scala

@@ -21,9 +21,6 @@ class ClassOf extends MiniPhaseTransform {
 
   override def phaseName: String = "classOf"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformTypeApply(tree: TypeApply)(implicit ctx: Context, info: TransformerInfo): Tree =
     if (tree.symbol eq defn.Predef_classOf) {
       val targ = tree.args.head.tpe

compiler/src/dotty/tools/dotc/transform/CollectEntryPoints.scala

@@ -24,9 +24,6 @@ import dotty.tools.dotc.config.JavaPlatform
 
 class CollectEntryPoints extends MiniPhaseTransform {
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** perform context-dependant initialization */
   override def prepareForUnit(tree: tpd.Tree)(implicit ctx: Context) = {
     entryPoints = collection.immutable.TreeSet.empty[Symbol](new SymbolOrdering())

compiler/src/dotty/tools/dotc/transform/Constructors.scala

@@ -39,9 +39,6 @@ class Constructors extends MiniPhaseTransform with IdentityDenotTransformer { th
     // performed before the rhs undergoes the owner change. This would lead
     // to more symbols being retained as parameters. Test case in run/capturing.scala.
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** The private vals that are known to be retained as class fields */
   private val retainedPrivateVals = mutable.Set[Symbol]()
 

compiler/src/dotty/tools/dotc/transform/CrossCastAnd.scala

@@ -19,9 +19,6 @@ class CrossCastAnd extends MiniPhaseTransform { thisTransform =>
 
   override def phaseName: String = "crossCast"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformSelect(tree: tpd.Select)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
 
     lazy val qtype = tree.qualifier.tpe.widen

compiler/src/dotty/tools/dotc/transform/DropInlined.scala

@@ -10,9 +10,6 @@ class DropInlined extends MiniPhaseTransform {
   import ast.tpd._
   override def phaseName = "dropInlined"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformInlined(tree: Inlined)(implicit ctx: Context, info: TransformerInfo): Tree =
     Inliner.dropInlined(tree)
 }

compiler/src/dotty/tools/dotc/transform/ElimByName.scala

@@ -42,10 +42,7 @@ class ElimByName extends TransformByNameApply with InfoTransformer { thisTransfo
 
   override def phaseName: String = "elimByName"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
- override def runsAfterGroupsOf = Set(classOf[Splitter])
+  override def runsAfterGroupsOf = Set(classOf[Splitter])
     // I got errors running this phase in an earlier group, but I did not track them down.
 
   /** Map `tree` to `tree.apply()` is `ftree` was of ExprType and becomes now a function */

compiler/src/dotty/tools/dotc/transform/ElimErasedValueType.scala

@@ -23,9 +23,6 @@ class ElimErasedValueType extends MiniPhaseTransform with InfoTransformer {
 
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[Erasure])
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   def transformInfo(tp: Type, sym: Symbol)(implicit ctx: Context): Type = sym match {
     case sym: ClassSymbol if sym is ModuleClass =>
       sym.companionClass match {

compiler/src/dotty/tools/dotc/transform/ElimOuterSelect.scala

@@ -17,9 +17,6 @@ class ElimOuterSelect extends MiniPhaseTransform { thisTransform =>
 
   override def phaseName: String = "elimOuterSelect"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def runsAfterGroupsOf = Set(classOf[ExplicitOuter])
     // ExplicitOuter needs to have run to completion before so that all classes
     // that need an outer accessor have one.

compiler/src/dotty/tools/dotc/transform/ElimRepeated.scala

@@ -30,10 +30,6 @@ class ElimRepeated extends MiniPhaseTransform with InfoTransformer { thisTransfo
 
   override def phaseName = "elimRepeated"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
-
   override def changesMembers = true // the phase adds vararg bridges
 
   def transformInfo(tp: Type, sym: Symbol)(implicit ctx: Context): Type =

compiler/src/dotty/tools/dotc/transform/ExpandPrivate.scala

@@ -41,9 +41,6 @@ class ExpandPrivate extends MiniPhaseTransform with IdentityDenotTransformer { t
 
   override def phaseName: String = "expandPrivate"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   // This phase moves methods around (in infotransform) so it may need to make other methods public
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[MoveStatics])
 

compiler/src/dotty/tools/dotc/transform/ExpandSAMs.scala

@@ -24,9 +24,6 @@ import dotty.tools.dotc.util.Positions.Position
 class ExpandSAMs extends MiniPhaseTransform { thisTransformer =>
   override def phaseName = "expandSAMs"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   import ast.tpd._
 
   /** Is the SAMType `cls` also a SAM under the rules of the platform? */

compiler/src/dotty/tools/dotc/transform/ExplicitOuter.scala

@@ -42,9 +42,6 @@ class ExplicitOuter extends MiniPhaseTransform with InfoTransformer { thisTransf
 
   override def phaseName: String = "explicitOuter"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** List of names of phases that should have finished their processing of all compilation units
     * before this phase starts
     */

compiler/src/dotty/tools/dotc/transform/ExplicitSelf.scala

@@ -28,9 +28,6 @@ class ExplicitSelf extends MiniPhaseTransform { thisTransform =>
 
   override def phaseName = "explicitSelf"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformIdent(tree: Ident)(implicit ctx: Context, info: TransformerInfo) = tree.tpe match {
     case tp: ThisType =>
       ctx.debuglog(s"owner = ${ctx.owner}, context = ${ctx}")

compiler/src/dotty/tools/dotc/transform/ExtensionMethods.scala

@@ -42,9 +42,6 @@ class ExtensionMethods extends MiniPhaseTransform with DenotTransformer with Ful
   import tpd._
   import ExtensionMethods._
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** the following two members override abstract members in Transform */
   override def phaseName: String = "extmethods"
 

compiler/src/dotty/tools/dotc/transform/FirstTransform.scala

@@ -40,9 +40,6 @@ class FirstTransform extends MiniPhaseTransform with InfoTransformer { thisTrans
 
   override def phaseName = "firstTransform"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   private[this] var addCompanionPhases: List[NeedsCompanions] = _
 
   override def changesMembers = true // the phase adds companion objects

compiler/src/dotty/tools/dotc/transform/FunctionXXLForwarders.scala

@@ -27,9 +27,6 @@ class FunctionXXLForwarders extends MiniPhaseTransform with IdentityDenotTransfo
 
   override def phaseName: String = "functionXXLForwarders"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformTemplate(impl: Template)(implicit ctx: Context, info: TransformerInfo): Template = {
 
     def forwarderRhs(receiver: Tree, xsTree: Tree): Tree =  {

compiler/src/dotty/tools/dotc/transform/FunctionalInterfaces.scala

@@ -26,9 +26,6 @@ class FunctionalInterfaces extends MiniPhaseTransform {
 
   def phaseName: String = "functionalInterfaces"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   val functionName = "JFunction".toTermName
   val functionPackage = "scala.compat.java8.".toTermName
 

compiler/src/dotty/tools/dotc/transform/GetClass.scala

@@ -20,9 +20,6 @@ class GetClass extends MiniPhaseTransform {
 
   override def phaseName: String = "getClass"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   // getClass transformation should be applied to specialized methods
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[Erasure], classOf[FunctionalInterfaces])
 

compiler/src/dotty/tools/dotc/transform/Getters.scala

@@ -51,9 +51,6 @@ class Getters extends MiniPhaseTransform with SymTransformer { thisTransform =>
 
   override def phaseName = "getters"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformSym(d: SymDenotation)(implicit ctx: Context): SymDenotation = {
     def noGetterNeeded =
       d.is(NoGetterNeeded) ||

compiler/src/dotty/tools/dotc/transform/HoistSuperArgs.scala

@@ -42,9 +42,6 @@ class HoistSuperArgs extends MiniPhaseTransform with IdentityDenotTransformer {
 
   def phaseName = "hoistSuperArgs"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def runsAfter = Set(classOf[ByNameClosures])
     // By name closures need to be introduced first in order to be hoisted out here.
     // There's an interaction with by name closures in that the <cbn-arg> marker

compiler/src/dotty/tools/dotc/transform/InterceptedMethods.scala

@@ -43,9 +43,6 @@ class InterceptedMethods extends MiniPhaseTransform {
 
   override def phaseName: String = "intercepted"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   private[this] var primitiveGetClassMethods: Set[Symbol] = _
 
   var Any_## : Symbol = _ // cached for performance reason

compiler/src/dotty/tools/dotc/transform/LambdaLift.scala

@@ -74,9 +74,6 @@ class LambdaLift extends MiniPhase with IdentityDenotTransformer { thisTransform
   class LambdaLifter extends TreeTransform {
     override def phase = thisTransform
 
-    override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-      groupEndPhase
-
     private type SymSet = TreeSet[Symbol]
 
     /** A map storing free variables of functions and classes */

compiler/src/dotty/tools/dotc/transform/LazyVals.scala

@@ -38,9 +38,6 @@ class LazyVals extends MiniPhaseTransform with IdentityDenotTransformer {
 
   override def phaseName: String = "LazyVals"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** List of names of phases that should have finished processing of tree
     * before this phase starts processing same tree */
   override def runsAfter = Set(classOf[Mixin])

compiler/src/dotty/tools/dotc/transform/LiftTry.scala

@@ -32,9 +32,6 @@ class LiftTry extends MiniPhase with IdentityDenotTransformer { thisTransform =>
   class Transform(needLift: Boolean) extends TreeTransform {
     def phase = thisTransform
 
-    override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-      groupEndPhase
-
     override def prepareForApply(tree: Apply)(implicit ctx: Context) =
       if (tree.fun.symbol.is(Label)) this
       else liftingTransform

compiler/src/dotty/tools/dotc/transform/LinkScala2Impls.scala

@@ -48,9 +48,6 @@ class LinkScala2Impls extends MiniPhase with IdentityDenotTransformer { thisTran
   class Transform extends TreeTransform {
     def phase = thisTransform
 
-    override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-      groupEndPhase
-
     /** Copy definitions from implementation class to trait itself */
     private def augmentScala_2_12_Trait(mixin: ClassSymbol)(implicit ctx: Context): Unit = {
       def info_2_12(sym: Symbol) = sym.info match {

compiler/src/dotty/tools/dotc/transform/Memoize.scala

@@ -37,9 +37,6 @@ import Decorators._
 
   override def phaseName = "memoize"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /* Makes sure that, after getters and constructors gen, there doesn't
    * exist non-deferred definitions that are not implemented. */
   override def checkPostCondition(tree: Tree)(implicit ctx: Context): Unit = {

compiler/src/dotty/tools/dotc/transform/Mixin.scala

@@ -98,9 +98,6 @@ class Mixin extends MiniPhaseTransform with SymTransformer { thisTransform =>
 
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[Erasure])
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def changesMembers = true  // the phase adds implementions of mixin accessors
 
   override def transformSym(sym: SymDenotation)(implicit ctx: Context): SymDenotation =

compiler/src/dotty/tools/dotc/transform/MoveStatics.scala

@@ -21,9 +21,6 @@ class MoveStatics extends MiniPhaseTransform with SymTransformer { thisTransform
   import tpd._
   override def phaseName = "moveStatic"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   def transformSym(sym: SymDenotation)(implicit ctx: Context): SymDenotation = {
     if (sym.hasAnnotation(defn.ScalaStaticAnnot) && sym.owner.is(Flags.Module) && sym.owner.companionClass.exists) {
       sym.owner.asClass.delete(sym.symbol)

compiler/src/dotty/tools/dotc/transform/NonLocalReturns.scala

@@ -24,9 +24,6 @@ class NonLocalReturns extends MiniPhaseTransform { thisTransformer =>
 
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[ElimByName])
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   private def ensureConforms(tree: Tree, pt: Type)(implicit ctx: Context) =
     if (tree.tpe <:< pt) tree
     else Erasure.Boxing.adaptToType(tree, pt)

compiler/src/dotty/tools/dotc/transform/NormalizeFlags.scala

@@ -17,9 +17,6 @@ import Flags._, Symbols._
 class NormalizeFlags extends MiniPhaseTransform with SymTransformer { thisTransformer =>
   override def phaseName = "normalizeFlags"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   def transformSym(ref: SymDenotation)(implicit ctx: Context) = {
     var newFlags = ref.flags &~ Local
     if (newFlags != ref.flags) ref.copySymDenotation(initFlags = newFlags)

compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala

@@ -27,9 +27,6 @@ class PatternMatcher extends MiniPhaseTransform {
   override def runsAfter = Set(classOf[ElimRepeated])
   override def runsAfterGroupsOf = Set(classOf[TailRec]) // tailrec is not capable of reversing the patmat tranformation made for tree
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def transformMatch(tree: Match)(implicit ctx: Context, info: TransformerInfo): Tree = {
     val translated = new Translator(tree.tpe, this).translateMatch(tree)
 

compiler/src/dotty/tools/dotc/transform/PhantomArgLift.scala

@@ -29,9 +29,6 @@ class PhantomArgLift extends MiniPhaseTransform {
 
   override def phaseName: String = "phantomArgLift"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   /** Check what the phase achieves, to be called at any point after it is finished. */
   override def checkPostCondition(tree: Tree)(implicit ctx: Context): Unit = tree match {
     case tree: Apply =>

compiler/src/dotty/tools/dotc/transform/PrimitiveForwarders.scala

@@ -35,9 +35,6 @@ class PrimitiveForwarders extends MiniPhaseTransform with IdentityDenotTransform
 
   override def phaseName: String = "primitiveForwarders"
 
-  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
-    groupEndPhase
-
   override def runsAfter = Set(classOf[ResolveSuper])
 
   override def changesMembers = true   // the phase adds primitive forwarders