Address review comments #774

Author: DarkDimius

src/dotty/tools/dotc/transform/Constructors.scala

@@ -41,9 +41,8 @@ class Constructors extends MiniPhaseTransform with SymTransformer { thisTransfor
   // 3. It is accessed on an object other than `this`
   // 4. It is a mutable parameter accessor
   // 5. It is has a wildcard initializer `_`
-  private var retainedPrivateVals = mutable.Set[Symbol]()
-  private var seenPrivateVals = mutable.Set[Symbol]()
-  private var insideConstructor = false
+  private val retainedPrivateVals = mutable.Set[Symbol]()
+  private val seenPrivateVals = mutable.Set[Symbol]()
 
   private def markUsedPrivateSymbols(tree: RefTree)(implicit ctx: Context): Unit = {
 
@@ -63,7 +62,6 @@ class Constructors extends MiniPhaseTransform with SymTransformer { thisTransfor
             if (inConstructor && (sym.is(ParamAccessor) || seenPrivateVals.contains(sym))) {
               // used inside constructor, accessed on this,
               // could use constructor argument instead, no need to retain field
-              println("hoha")
             }
             else retain
           case _ => retain
@@ -81,7 +79,6 @@ class Constructors extends MiniPhaseTransform with SymTransformer { thisTransfor
     tree
   }
 
-
   override def transformValDef(tree: tpd.ValDef)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     if (mightBeDropped(tree.symbol))
       (if (isWildcardStarArg(tree.rhs)) retainedPrivateVals else seenPrivateVals) += tree.symbol
@@ -254,8 +251,7 @@ class Constructors extends MiniPhaseTransform with SymTransformer { thisTransfor
         info = clsInfo.derivedClassInfo(
           decls = clsInfo.decls.filteredScope(!dropped.contains(_))))
 
-      // TODO: this happens to work only because Constructors is the last phase in group
-    }
+      // TODO: this happens to work only because Constructors is the last phase in groupp    }
 
     val (superCalls, followConstrStats) = constrStats.toList match {
       case (sc: Apply) :: rest if sc.symbol.isConstructor => (sc :: Nil, rest)