Skip to content

Commit 53cd512

Browse files
committed
Disable context escape detection
I get very frequent build failures due to the mutual Scala<->Java dependency. It builds for a long time, then decides that getCtx overrides nothing. The only way to fix is another clean build. Total time lost: >5 minutes. These happened occasionally before but have become much more frequent under ScalaIDe4.0, to the point where this becomes a major drag on productity. Context escape detection is nice but if it stops us getting work done, not worth the effort.
1 parent 13ec91b commit 53cd512

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/test/DottyTest.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import dotty.tools.dotc.Compiler
1414
import dotty.tools.dotc
1515
import dotty.tools.dotc.core.Phases.Phase
1616

17-
class DottyTest extends ContextEscapeDetection{
17+
class DottyTest /*extends ContextEscapeDetection*/ {
1818

1919
dotty.tools.dotc.parsing.Scanners // initialize keywords
2020

@@ -36,11 +36,12 @@ class DottyTest extends ContextEscapeDetection{
3636
base.definitions.init(ctx)
3737
ctx
3838
}
39-
39+
/*
4040
override def getCtx: Context = ctx
4141
override def clearCtx() = {
4242
ctx = null
4343
}
44+
*/
4445
private def compilerWithChecker(phase: String)(assertion:(tpd.Tree, Context) => Unit) = new Compiler {
4546
self =>
4647
override def phases = {

0 commit comments

Comments
 (0)