Alternative fix for #2506 that does not force dirs

nicolasstucki · nicolasstucki · commit 4d354a7c2383 · 2017-07-26T10:04:14.000+02:00
As stated in #2506 `lazy` was droped to make it volatile. It turns out that the dirs is not always used and epensive to compute. In `implicit_cache.scala` only need dirs 1 out of 30 times.
diff --git a/compiler/src/dotty/tools/io/ZipArchive.scala b/compiler/src/dotty/tools/io/ZipArchive.scala
@@ -149,7 +149,7 @@ final class FileZipArchive(file: JFile) extends ZipArchive(file) {
     override def sizeOption: Option[Int] = Some(zipEntry.getSize.toInt)
   }
 
-  val (root, allDirs) = {
+  @volatile lazy val (root, allDirs) = {
     val root = new DirEntry("/")
     val dirs = mutable.HashMap[String, DirEntry]("/" -> root)
     val zipFile = openZipFile()

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ final class FileZipArchive(file: JFile) extends ZipArchive(file) {`
`149`	`149`	`override def sizeOption: Option[Int] = Some(zipEntry.getSize.toInt)`
`150`	`150`	`}`
`151`	`151`
`152`		`- val (root, allDirs) = {`
	`152`	`+ @volatile lazy val (root, allDirs) = {`
`153`	`153`	`val root = new DirEntry("/")`
`154`	`154`	`val dirs = mutable.HashMap[String, DirEntry]("/" -> root)`
`155`	`155`	`val zipFile = openZipFile()`