Don't depend on JVM's Annotation toString impl

Author: dwijnand

a.check

@@ -0,0 +1,8 @@
+inspecting field value
+@JsonProperty("REAL_VALUE")
+inspecting method getValue
+@JsonProperty("REAL_VALUE")
+inspecting method setValue
+inspecting method value
+inspecting method value_$eq
+inspecting constructor TestBeanProperty

tests/run/i12492.check

@@ -1,7 +1,7 @@
 inspecting field brandName
-@MyColumnBase(name="BRAND_NAME")
+interface MyColumnBase
 inspecting field companyName
-@MyColumnBase(name="COMPANY_NAME")
+interface MyColumnBase
 inspecting method brandName
 inspecting method companyName
 inspecting constructor MyTable

tests/run/i12492/MyTable.scala

@@ -8,29 +8,3 @@ class MyTable(
   @MyColumn(name="COMPANY_NAME")
   val companyName: String,
 )
-
-object Test:
-  def main(args: Array[String]): Unit =
-    val clasz = classOf[MyTable]
-
-    for (m <- clasz.getDeclaredFields.sortBy(_.getName)) {
-      m.setAccessible(true)
-      println(s"inspecting field ${m.getName}")
-      for a <- m.getAnnotations().sortBy(_.toString) do
-        println(a)
-    }
-
-    for (m <- clasz.getDeclaredMethods.sortBy(_.getName)) {
-      m.setAccessible(true)
-      println(s"inspecting method ${m.getName}")
-      for a <- m.getAnnotations().sortBy(_.toString) do
-        println(a)
-    }
-
-    for c <- clasz.getDeclaredConstructors.sortBy(_.getName) do
-      c.setAccessible(true)
-      println(s"inspecting constructor ${c.getName}")
-      for p <- c.getParameters.sortBy(_.getName) do
-        println(s"inspecting param ${p.getName}")
-        for a <- p.getAnnotations.sortBy(_.toString) do
-          println(s"annotation $a")

tests/run/i12492/Test.scala

@@ -0,0 +1,25 @@
+object Test:
+  def main(args: Array[String]): Unit =
+    val cls = classOf[MyTable]
+
+    for (m <- cls.getDeclaredFields.sortBy(_.getName)) {
+      m.setAccessible(true)
+      println(s"inspecting field ${m.getName}")
+      for a <- m.getAnnotations().sortBy(_.annotationType.toString) do
+        println(a.annotationType)
+    }
+
+    for (m <- cls.getDeclaredMethods.sortBy(_.getName)) {
+      m.setAccessible(true)
+      println(s"inspecting method ${m.getName}")
+      for a <- m.getAnnotations().sortBy(_.annotationType.toString) do
+        println(a.annotationType)
+    }
+
+    for c <- cls.getDeclaredConstructors.sortBy(_.getName) do
+      c.setAccessible(true)
+      println(s"inspecting constructor ${c.getName}")
+      for p <- c.getParameters.sortBy(_.getName) do
+        println(s"inspecting param ${p.getName}")
+        for a <- p.getAnnotations.sortBy(_.annotationType.toString) do
+          println(a.annotationType)

tests/run/i15318.check

@@ -1,7 +1,7 @@
 inspecting field value
-@JsonProperty(value="REAL_VALUE")
+interface JsonProperty
 inspecting method getValue
-@JsonProperty(value="REAL_VALUE")
+interface JsonProperty
 inspecting method setValue
 inspecting method value
 inspecting method value_$eq

tests/run/i15318/Test.scala

@@ -1,25 +1,25 @@
 object Test:
   def main(args: Array[String]): Unit =
-    val clasz = classOf[TestBeanProperty]
+    val cls = classOf[TestBeanProperty]
 
-    for (m <- clasz.getDeclaredFields.sortBy(_.getName)) {
+    for (m <- cls.getDeclaredFields.sortBy(_.getName)) {
       m.setAccessible(true)
       println(s"inspecting field ${m.getName}")
-      for a <- m.getAnnotations().sortBy(_.toString) do
-        println(a)
+      for a <- m.getAnnotations().sortBy(_.annotationType.toString) do
+        println(a.annotationType)
     }
 
-    for (m <- clasz.getDeclaredMethods.sortBy(_.getName)) {
+    for (m <- cls.getDeclaredMethods.sortBy(_.getName)) {
       m.setAccessible(true)
       println(s"inspecting method ${m.getName}")
-      for a <- m.getAnnotations().sortBy(_.toString) do
-        println(a)
+      for a <- m.getAnnotations().sortBy(_.annotationType.toString) do
+        println(a.annotationType)
     }
 
-    for c <- clasz.getDeclaredConstructors.sortBy(_.getName) do
+    for c <- cls.getDeclaredConstructors.sortBy(_.getName) do
       c.setAccessible(true)
       println(s"inspecting constructor ${c.getName}")
       for p <- c.getParameters.sortBy(_.getName) do
         println(s"inspecting param ${p.getName}")
-        for a <- p.getAnnotations.sortBy(_.toString) do
-          println(s"annotation $a")
+        for a <- p.getAnnotations.sortBy(_.annotationType.toString) do
+          println(a.annotationType)