Remove {neg-custom-args,pos-special}/isInstanceOf

Author: dwijnand

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -37,19 +37,14 @@ class CompilationTests {
       compileFilesInDir("tests/pos-special/fatal-warnings", defaultOptions.and("-Xfatal-warnings", "-deprecation", "-feature")),
       compileFilesInDir("tests/pos-special/spec-t5545", defaultOptions),
       compileFilesInDir("tests/pos-special/strawman-collections", allowDeepSubtypes),
-      compileFilesInDir("tests/pos-special/isInstanceOf", allowDeepSubtypes.and("-Xfatal-warnings")),
       compileFilesInDir("tests/new", defaultOptions.and("-source", "3.2")), // just to see whether 3.2 works
       compileFilesInDir("tests/pos-scala2", scala2CompatMode),
       compileFilesInDir("tests/pos-custom-args/erased", defaultOptions.and("-language:experimental.erasedDefinitions")),
       compileFilesInDir("tests/pos", defaultOptions.and("-Ysafe-init")),
       compileFilesInDir("tests/pos-deep-subtype", allowDeepSubtypes),
       compileFilesInDir("tests/pos-custom-args/no-experimental", defaultOptions.and("-Yno-experimental")),
       compileDir("tests/pos-special/java-param-names", defaultOptions.withJavacOnlyOptions("-parameters")),
-      compileFile(
-        // succeeds despite -Xfatal-warnings because of -nowarn
-        "tests/neg-custom-args/fatal-warnings/xfatalWarnings.scala",
-        defaultOptions.and("-nowarn", "-Xfatal-warnings")
-      ),
+      compileFile("tests/neg-custom-args/fatal-warnings/xfatalWarnings.scala", defaultOptions.and("-nowarn", "-Xfatal-warnings")), // succeeds despite -Xfatal-warnings because of -nowarn
       compileFile("tests/pos-special/typeclass-scaling.scala", defaultOptions.and("-Xmax-inlines", "40")),
       compileFile("tests/pos-special/i7296.scala", defaultOptions.and("-source", "future", "-deprecation", "-Xfatal-warnings")),
       compileDir("tests/pos-special/adhoc-extension", defaultOptions.and("-source", "future", "-feature", "-Xfatal-warnings")),
@@ -162,7 +157,6 @@ class CompilationTests {
       compileFile("tests/neg-custom-args/i15575.scala", defaultOptions.and("-explain")),
       compileFile("tests/neg-custom-args/interop-polytypes.scala", allowDeepSubtypes.and("-Yexplicit-nulls")),
       compileFile("tests/neg-custom-args/conditionalWarnings.scala", allowDeepSubtypes.and("-deprecation").and("-Xfatal-warnings")),
-      compileFilesInDir("tests/neg-custom-args/isInstanceOf", allowDeepSubtypes and "-Xfatal-warnings"),
       compileFile("tests/neg-custom-args/i3627.scala", allowDeepSubtypes),
       compileFile("tests/neg-custom-args/sourcepath/outer/nested/Test1.scala", defaultOptions.and("-sourcepath", "tests/neg-custom-args/sourcepath")),
       compileDir("tests/neg-custom-args/sourcepath2/hi", defaultOptions.and("-sourcepath", "tests/neg-custom-args/sourcepath2", "-Xfatal-warnings")),

tests/neg-custom-args/isInstanceOf/i5495.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Test {
   def remove[S](a: S | Int, f: Int => S):S = a match {
     case a: S => a             // error

tests/neg-custom-args/isInstanceOf/1828.scala renamed to tests/neg/1828.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class C[T] {
   val x: Any = ???
   if (x.isInstanceOf[List[String]]) // error: unchecked

tests/neg-custom-args/isInstanceOf/3324b.scala renamed to tests/neg/3324b.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 trait C[T]
 class D[T]
 
@@ -6,4 +7,4 @@ class Test {
     case _: D[T] =>    // error
     case _: C[Int] =>  // error
   }
-}
+}

tests/neg-custom-args/isInstanceOf/3324f.scala renamed to tests/neg/3324f.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Test {
   trait A[+T]
   class B[T] extends A[T]

tests/neg-custom-args/isInstanceOf/3324g.scala renamed to tests/neg/3324g.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 object Test {
   trait Foo
   case class One[+T](fst: T)

tests/neg-custom-args/isInstanceOf/4075.scala.ignore renamed to tests/neg/4075.scala.ignore

@@ -1,3 +1,4 @@
+// scalac: -Werror
 object Test1 {
   trait Tree[-T]
 
@@ -26,4 +27,4 @@ object Test2 {
     tree.isInstanceOf[JavaSeqLiteral[Type]]
 
   foo1(new DummyTree)
-}
+}

tests/neg-custom-args/isInstanceOf/JavaSeqLiteral.scala renamed to tests/neg/JavaSeqLiteral.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 sealed trait Exp[T]
 case class Fun[A, B](f: Exp[A => B]) extends Exp[A => B]
 
@@ -7,4 +8,4 @@ class Test {
     case Fun(x: Exp[Int => String]) => ???        // error
     case _ =>
   }
-}
+}

tests/neg-custom-args/isInstanceOf/enum-approx2.scala renamed to tests/neg/enum-approx2.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Test {
   trait A[+T]
   class B[T] extends A[T]
@@ -10,4 +11,4 @@ class Test {
   }
 
   quux(new B[D])
-}
+}

tests/neg-custom-args/isInstanceOf/gadt.scala renamed to tests/neg/gadt.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 object HTML:
   type AttrArg = AppliedAttr | Seq[AppliedAttr]
   opaque type AppliedAttr = String

tests/neg-custom-args/isInstanceOf/html.scala renamed to tests/neg/html.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 trait Box[+T]
 case class Foo[+S](s: S) extends Box[S]
 
@@ -36,4 +37,4 @@ object Test3 {
       case _: Bar[Boolean] => ??? // error
       case _ => ???
     }
-}
+}

tests/neg-custom-args/isInstanceOf/i11178.scala renamed to tests/neg/i11178.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Foo {
   def foo(x: Any): Boolean =
     x.isInstanceOf[List[String]]  // error

tests/neg-custom-args/isInstanceOf/i3324.scala renamed to tests/neg/i3324.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Test {
   def test[X <: Option[Int]](x: X) = x.isInstanceOf[Some[Int]]
   def test1[Y <: Int, X <: Option[Y]](x: X) = x.isInstanceOf[Some[Int]]

tests/neg-custom-args/isInstanceOf/i4297.scala renamed to tests/neg/i4297.scala

@@ -1,4 +1,18 @@
+// scalac: -Werror
+
 lazy enum LazyList[+A] {  // error: sealed abstract types cannot be lazy enum
   case ::[A] (head: A, tail: LazyList[A]) extends LazyList[A]
   case Nil
 }
+
+class A
+class B
+
+type AorB = A | B
+
+def foo(any: Any) = any match {
+  case aorb: AorB =>
+  case _ =>
+}
+
+def bar[T](x: List[T]) = x.isInstanceof[List[Int]] // error

tests/neg/i5495.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Foo {
   def test[A]: List[Int] | A => Int = {
     case ls: List[Int] => ls.head       // error

tests/neg-custom-args/isInstanceOf/i5826.scala renamed to tests/neg/i5826.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class Foo {
   def test1[A]: List[Int] | A => Int = {
     case ls: List[_] => ls.head       // error

tests/neg-custom-args/isInstanceOf/i5826b.scala renamed to tests/neg/i5826b.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 sealed trait Foo[+A]
 case class Bar[A]() extends Foo[A]
 
@@ -9,4 +10,4 @@ def bugReport[A](foo: Foo[A]): Foo[A] =
     case dummy: Dummy => ???
   }
 
-def test = bugReport(new Dummy: Foo[String])
+def test = bugReport(new Dummy: Foo[String])

tests/neg-custom-args/isInstanceOf/i8932.scala renamed to tests/neg/i8932.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 object Test1 {
   trait Tree
   trait Context
@@ -35,4 +36,4 @@ object Test2 {
     myTree match
       case treeFn: (_ => _) =>       // ok
       case _ =>
-}
+}

tests/neg-custom-args/isInstanceOf/or-type-trees.scala renamed to tests/neg/or-type-trees.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class A[-T]
 class B[T] extends A[T]
 

tests/neg-custom-args/isInstanceOf/patmat-applied.scala renamed to tests/neg/patmat-applied.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class A
 class B extends A
 type AA = A { type T = Int }

tests/neg-custom-args/isInstanceOf/refined-types.scala renamed to tests/neg/refined-types.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 // Test cases: the only place we can cut and paste without crying
 // ourself to sleep.
 object Test {

tests/neg-custom-args/isInstanceOf/t2755.scala renamed to tests/neg/t2755.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 trait A[T]
 trait B[T] extends A[T]
 

tests/neg-custom-args/isInstanceOf/type-lambda.scala renamed to tests/neg/type-lambda.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 sealed trait A[T]
 class B[T] extends A[T]
 

tests/pos-special/isInstanceOf/Result.scala

@@ -1,8 +1,9 @@
+// scalac: -Werror
 class Test {
   val x: Any = ???
 
   x match {
     case _: List[Int @unchecked] => 5
     case _: Option[Int] @unchecked => 5
   }
-}
+}

tests/pos-special/isInstanceOf/i9782.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 class C[T] {
   val x: T = ???
   x.isInstanceOf[T]

tests/pos-special/isInstanceOf/3324c.scala renamed to tests/pos/3324c.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 object Test {
   trait Marker
   def foo[T](x: T) = x match {

tests/pos-special/isInstanceOf/3324d.scala renamed to tests/pos/3324d.scala

@@ -1,6 +1,8 @@
+// scalac: -Werror
 import scala.util.control.NonFatal
 object p {
 
+  // test parametric case classes, which synthesis `canEqual` and `equals`
   enum Result[+T, +E] {
     case OK [T](x: T) extends Result[T, Nothing]
     case Err[E](e: E) extends Result[Nothing, E]

tests/pos-special/isInstanceOf/3324e.scala renamed to tests/pos/3324e.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 import scala.reflect.ClassTag
 
 object IsInstanceOfClassTag {
@@ -7,4 +8,4 @@ object IsInstanceOfClassTag {
       case _ => None
     }
   }
-}
+}

tests/pos-special/isInstanceOf/3324h.scala renamed to tests/pos/3324h.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 sealed trait Exp[T]
 case class Num(n: Int) extends Exp[Int]
 case class Plus(e1: Exp[Int], e2: Exp[Int]) extends Exp[Int]

tests/pos/Result.scala

@@ -1,7 +1,8 @@
+// scalac: -Werror
 class Test {
   type MyCombo = Int | Unit
   val z: MyCombo = 10
    z match
     case i: Int => ???
     case _ => ???
-}
+}

tests/pos-special/isInstanceOf/classTag.scala renamed to tests/pos/classTag.scala

@@ -1,3 +1,4 @@
+// scalac: -Werror
 trait Txn[T <: Txn[T]]
 
 trait Elem[T <: Txn[T]]
@@ -17,3 +18,13 @@ trait Copy[In <: Txn[In], Out <: Txn[Out]] {
     out
   }
 }
+
+class Test {
+
+  def apply[Repr[~ <: Txn[~]] <: Elem[~], In <: Txn[In]](in: Repr[In]): Unit = {
+    in match {
+      case inObj: Obj[In] =>     // problem here
+      case _ =>
+    }
+  }
+}