Skip to content

Commit 397cbf6

Browse files
committed
Dotty IDE: Do not highlight constructors
They're always synthetic, they shouldn't be highlighted.
1 parent b61613b commit 397cbf6

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ class DottyLanguageServer extends LanguageServer
382382
else {
383383
val refs = Interactive.namedTrees(uriTrees, Include.references | Include.overriding, sym)
384384
(for {
385-
ref <- refs
385+
ref <- refs if !ref.tree.symbol.isConstructor
386386
nameRange <- range(ref.namePos)
387387
} yield new DocumentHighlight(nameRange, DocumentHighlightKind.Read)).asJava
388388
}

language-server/test/dotty/tools/languageserver/HighlightTest.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,10 @@ class HighlightTest {
1919
.highlight(xRef.range, (xDef.range, DocumentHighlightKind.Read), (xRef.range, DocumentHighlightKind.Read))
2020
}
2121

22+
@Test def highlightClass(): Unit = {
23+
code"""class ${m1}Foo${m2} { new ${m3}Foo${m4} }""".withSource
24+
.highlight(m1 to m2, (m1 to m2, DocumentHighlightKind.Read), (m3 to m4, DocumentHighlightKind.Read))
25+
.highlight(m3 to m4, (m1 to m2, DocumentHighlightKind.Read), (m3 to m4, DocumentHighlightKind.Read))
26+
}
27+
2228
}

0 commit comments

Comments
 (0)