Add explicit check against self-annotated classes

Following the completions-related changes in this PR, we no longer
encounter cyclic reference errors when annotating a class with
itself (i1212.scala) as well as in some situation where an annotation
class indirectly refers to itself (i3506.scala).

While the latter is OK, the former is problematic because when
unpickling from tasty, the modifiers and annotations of a symbol are read
before the symbol itself is created, so we can't support self-annotation
classes, we therefore need to disallow them explicitly.

Author: smarter

compiler/src/dotty/tools/dotc/typer/Namer.scala

@@ -791,10 +791,14 @@ class Namer { typer: Typer =>
         lazy val annotCtx = annotContext(original, sym)
         for (annotTree <- untpd.modsDeco(original).mods.annotations) {
           val cls = typedAheadAnnotationClass(annotTree)(annotCtx)
-          val ann = Annotation.deferred(cls, implicit ctx => typedAnnotation(annotTree))
-          sym.addAnnotation(ann)
-          if (cls == defn.ForceInlineAnnot && sym.is(Method, butNot = Accessor))
-            sym.setFlag(Inline)
+          if (cls eq sym)
+            ctx.error("An annotation class cannot be annotated with iself", annotTree.sourcePos)
+          else {
+            val ann = Annotation.deferred(cls, implicit ctx => typedAnnotation(annotTree))
+            sym.addAnnotation(ann)
+            if (cls == defn.ForceInlineAnnot && sym.is(Method, butNot = Accessor))
+              sym.setFlag(Inline)
+          }
         }
       case _ =>
     }

tests/neg/i1212.scala

@@ -1 +1 @@
-@ann class ann extends scala.annotation.Annotation // error: cyclic reference
+@ann class ann extends scala.annotation.Annotation // error: An annotation class cannot be annotated with iself

tests/neg/i3506.scala

@@ -0,0 +1,2 @@
+trait C2[@specialized A]
+class specialized extends scala.annotation.StaticAnnotation with C2[Char]