Add macro annotation ill-abort test

Author: nicolasstucki

compiler/src/dotty/tools/dotc/transform/MacroAnnotations.scala

@@ -66,7 +66,7 @@ class MacroAnnotations(thisPhase: DenotTransformer):
                 ex0.getCause match
                   case ex: scala.quoted.runtime.StopMacroExpansion =>
                     if !ctx.reporter.hasErrors then
-                      report.error("Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users to facilitate debugging when aborting a macro expansion.", annot.tree)
+                      report.error("Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users when aborting a macro expansion with StopMacroExpansion.", annot.tree)
                     List(tree)
                   case Interpreter.MissingClassDefinedInCurrentRun(sym) =>
                     Interpreter.suspendOnMissing(sym, annot.tree)

compiler/src/dotty/tools/dotc/transform/Splicer.scala

@@ -69,7 +69,7 @@ object Splicer {
           throw ex
         case ex: scala.quoted.runtime.StopMacroExpansion =>
           if !ctx.reporter.hasErrors then
-            report.error("Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users to facilitate debugging when aborting a macro expansion.", splicePos)
+            report.error("Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users when aborting a macro expansion with StopMacroExpansion.", splicePos)
           // errors have been emitted
           EmptyTree
         case ex: StopInterpretation =>

tests/neg-macros/annot-ill-abort.check

@@ -0,0 +1,5 @@
+
+-- Error: tests/neg-macros/annot-ill-abort/Test_2.scala:1:0 ------------------------------------------------------------
+1 |@crash // error
+  |^^^^^^
+  |Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users when aborting a macro expansion with StopMacroExpansion.

tests/neg-macros/annot-ill-abort/Macro_1.scala

@@ -0,0 +1,8 @@
+import scala.annotation.{experimental, MacroAnnotation}
+import scala.quoted._
+
+@experimental
+class crash extends MacroAnnotation {
+  def transform(using Quotes)(tree: quotes.reflect.Definition): List[quotes.reflect.Definition] =
+    throw new scala.quoted.runtime.StopMacroExpansion
+}

tests/neg-macros/annot-ill-abort/Test_2.scala

@@ -0,0 +1,2 @@
+@crash // error
+def test = ()

tests/neg-macros/ill-abort.check

@@ -2,7 +2,7 @@
 -- Error: tests/neg-macros/ill-abort/quoted_2.scala:1:15 ---------------------------------------------------------------
 1 |def test = fail() // error
   |           ^^^^^^
-  |Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users to facilitate debugging when aborting a macro expansion.
+  |Macro expansion was aborted by the macro without any errors reported. Macros should issue errors to end-users when aborting a macro expansion with StopMacroExpansion.
   |---------------------------------------------------------------------------------------------------------------------
   |Inline stack trace
   |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -