Split isSplice into isExprSplice and isTypeSlpice

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/TreeInfo.scala

@@ -884,7 +884,7 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] =>
      *  will return a term tree.
      */
     def unapply(tree: tpd.Apply)(using Context): Option[tpd.Tree] =
-      if tree.symbol.isSplice then Some(tree.args.head) else None
+      if tree.symbol.isExprSplice then Some(tree.args.head) else None
   }
 
   /** Extractors for type splices */
@@ -894,7 +894,7 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] =>
       *  will return a type tree.
       */
     def unapply(tree: tpd.Select)(using Context): Option[tpd.Tree] =
-      if tree.symbol.isSplice then Some(tree.qualifier) else None
+      if tree.symbol.isTypeSplice then Some(tree.qualifier) else None
   }
 
   /** Extractor for not-null assertions.

compiler/src/dotty/tools/dotc/transform/PCPCheckAndHeal.scala

@@ -179,7 +179,7 @@ class PCPCheckAndHeal(@constructorOnly ictx: Context) extends TreeMapWithStages(
               tryHeal(tp.symbol, tp, pos)
             case prefix: ThisType if !tp.symbol.isStatic && level > levelOf(prefix.cls) =>
               tryHeal(tp.symbol, tp, pos)
-            case prefix: TermRef if tp.symbol.isSplice =>
+            case prefix: TermRef if tp.symbol.isTypeSplice =>
               prefix.symbol.info.argInfos match
                 case (tb: TypeBounds) :: _ =>
                   ctx.error(em"Cannot splice $tp because it is a wildcard type", pos)

compiler/src/dotty/tools/dotc/transform/ReifyQuotes.scala

@@ -78,7 +78,8 @@ class ReifyQuotes extends MacroTransform {
     tree match {
       case tree: RefTree if !Inliner.inInlineMethod =>
         assert(!tree.symbol.isQuote)
-        assert(!tree.symbol.isSplice)
+        assert(!tree.symbol.isExprSplice)
+        assert(!tree.symbol.isTypeSplice)
       case _ : TypeDef =>
         assert(!tree.symbol.hasAnnotation(defn.InternalQuoted_QuoteTypeTagAnnot),
           s"${tree.symbol} should have been removed by PickledQuotes because it has a @quoteTypeTag")
@@ -329,7 +330,7 @@ class ReifyQuotes extends MacroTransform {
       /** Remove references to local types that will not be defined in this quote */
       def getTypeHoleType(using ctx: Context) = new TypeMap() {
         override def apply(tp: Type): Type = tp match
-          case tp: TypeRef if tp.typeSymbol.isSplice =>
+          case tp: TypeRef if tp.typeSymbol.isTypeSplice =>
             apply(tp.dealias)
           case tp @ TypeRef(pre, _) if pre == NoPrefix || pre.termSymbol.isLocal =>
             val hiBound = tp.typeSymbol.info match

compiler/src/dotty/tools/dotc/transform/SymUtils.scala

@@ -208,9 +208,13 @@ class SymUtils(val self: Symbol) extends AnyVal {
   def isQuote(using Context): Boolean =
     self == defn.InternalQuoted_exprQuote || self == defn.InternalQuoted_typeQuote
 
-  /** Is symbol a splice operation? */
-  def isSplice(using Context): Boolean =
-    self == defn.InternalQuoted_exprSplice || self == defn.InternalQuoted_exprNestedSplice || self == defn.QuotedType_splice
+  /** Is symbol a term splice operation? */
+  def isExprSplice(using Context): Boolean =
+    self == defn.InternalQuoted_exprSplice || self == defn.InternalQuoted_exprNestedSplice
+
+  /** Is symbol a type splice operation? */
+  def isTypeSplice(using Context): Boolean =
+    self == defn.QuotedType_splice
 
   /** Is symbol an extension method? Accessors are excluded since
    *  after the getters phase collective extension objects become accessors