Skip to content

Commit 2b88f1c

Browse files
committed
Address review comments
- rename `exludes` --> `excludes` - fix comments
1 parent 8afe649 commit 2b88f1c

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

compiler/src/dotty/tools/dotc/transform/Recheck.scala

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ abstract class Recheck extends Phase, IdentityDenotTransformer:
3434
// One failing test is pos/i583a.scala
3535

3636
def run(using Context): Unit =
37-
val unit = ctx.compilationUnit
38-
//println(i"recheck types of $unit")
39-
newRechecker().checkUnit(unit)
37+
newRechecker().checkUnit(ctx.compilationUnit)
4038

4139
def newRechecker()(using Context): Rechecker
4240

@@ -94,7 +92,7 @@ abstract class Recheck extends Phase, IdentityDenotTransformer:
9492
def recheckBind(tree: Bind, pt: Type)(using Context): Type = tree match
9593
case Bind(name, body) =>
9694
enterDef(tree)
97-
val bodyType = recheck(body, pt)
95+
recheck(body, pt)
9896
val sym = tree.symbol
9997
if sym.isType then sym.typeRef else sym.info
10098

@@ -249,11 +247,9 @@ abstract class Recheck extends Phase, IdentityDenotTransformer:
249247
stats.foreach(enterDef)
250248
stats.foreach(recheck(_))
251249

252-
/** Typecheck tree without adapting it, returning a recheck tree.
253-
* @param initTree the unrecheck tree
250+
/** Recheck tree without adapting it, returning its new type.
251+
* @param tree the original tree
254252
* @param pt the expected result type
255-
* @param locked the set of type variables of the current typer state that cannot be interpolated
256-
* at the present time
257253
*/
258254
def recheck(tree: Tree, pt: Type = WildcardType)(using Context): Type = trace(i"rechecking $tree with pt = $pt", recheckr, show = true) {
259255

compiler/test/dotty/tools/TestSources.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ object TestSources {
1111

1212
def posFromTastyBlacklistFile: String = "compiler/test/dotc/pos-from-tasty.blacklist"
1313
def posTestPicklingBlacklistFile: String = "compiler/test/dotc/pos-test-pickling.blacklist"
14-
def posTestRecheckExcludesFile = "compiler/test/dotc/pos-test-recheck.exludes"
14+
def posTestRecheckExcludesFile = "compiler/test/dotc/pos-test-recheck.excludes"
1515

1616
def posFromTastyBlacklisted: List[String] = loadList(posFromTastyBlacklistFile)
1717
def posTestPicklingBlacklisted: List[String] = loadList(posTestPicklingBlacklistFile)
@@ -21,7 +21,7 @@ object TestSources {
2121

2222
def runFromTastyBlacklistFile: String = "compiler/test/dotc/run-from-tasty.blacklist"
2323
def runTestPicklingBlacklistFile: String = "compiler/test/dotc/run-test-pickling.blacklist"
24-
def runTestRecheckExcludesFile = "compiler/test/dotc/run-test-recheck.exludes"
24+
def runTestRecheckExcludesFile = "compiler/test/dotc/run-test-recheck.excludes"
2525

2626
def runFromTastyBlacklisted: List[String] = loadList(runFromTastyBlacklistFile)
2727
def runTestPicklingBlacklisted: List[String] = loadList(runTestPicklingBlacklistFile)

0 commit comments

Comments
 (0)