Further review changes + fixed bug with displaying old results on rare occasions

Author: KacperFKorban

scaladoc-js/src/searchbar/SearchbarComponent.scala

@@ -78,17 +78,19 @@ class SearchbarComponent(engine: SearchbarEngine, inkuireEngine: InkuireJSSearch
         handleNewFluffQuery(matchers)
       case BySignature(signature) =>
         timeoutHandle = setTimeout(1.second) {
+          val properResultsDiv = document.createElement("div").asInstanceOf[html.Div]
+          resultsDiv.appendChild(properResultsDiv)
           val loading = document.createElement("div").asInstanceOf[html.Div]
           loading.classList.add("loading-wrapper")
           val animation = document.createElement("div").asInstanceOf[html.Div]
           animation.classList.add("loading")
           loading.appendChild(animation)
-          resultsDiv.appendChild(loading)
+          properResultsDiv.appendChild(loading)
           inkuireEngine.query(query) { (p: PageEntry) =>
-            resultsDiv.appendChild(p.toHTML(inkuire = true))
+            properResultsDiv.appendChild(p.toHTML(inkuire = true))
           } { (s: String) =>
             animation.classList.remove("loading")
-            resultsDiv.appendChild(s.toHTMLError)
+            properResultsDiv.appendChild(s.toHTMLError)
           }
         }
     }

scaladoc/resources/dotty_res/styles/search-bar.css

@@ -84,6 +84,7 @@
 }
 
 .loading {
+  left: 50%;
   position: relative;
   animation-delay: .5s;
 }

scaladoc/src/dotty/tools/scaladoc/Scaladoc.scala

@@ -89,16 +89,11 @@ object Scaladoc:
 
   def dumpInkuireDB(output: String, parsedArgs: Args) = {
     val dbPath = Paths.get(output, "inkuire-db.json")
-    println("InkuireDB created successfully!")
-    println(s"Types: ${Inkuire.db.types.size}")
-    println(s"Functions: ${Inkuire.db.functions.size}")
-    println(s"ImplicitConversions: ${Inkuire.db.implicitConversions.size}")
     val dbFile = dbPath.toFile()
     dbFile.createNewFile()
     val dbWriter = new FileWriter(dbFile, false)
     dbWriter.write(s"${EngineModelSerializers.serialize(Inkuire.db)}")
     dbWriter.close()
-    println(s"Saved InkuireDB in file: ${dbPath.toString}")
 
     val configPath = Paths.get(output, "scripts/inkuire-config.json")
     val configFile = configPath.toFile()