Fix #10888: Avoid A.this.B for Java inner classes

For Java inner classes, we should use `A#B` instead of `A.this.B`.

Co-authored-by: Guillaume Martres <[email protected]>

Author: liufengyun

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -349,12 +349,18 @@ class ClassfileParser(
       val tag = sig(index); index += 1
       (tag: @switch) match {
         case 'L' =>
-          def processInner(tp: Type): Type = tp match {
-            case tp: TypeRef if !tp.symbol.owner.is(Flags.ModuleClass) =>
-              TypeRef(processInner(tp.prefix.widen), tp.symbol.asType)
-            case _ =>
-              tp
-          }
+          /** Inner class references of A.this.B into A#B, do the same transformation recursively on `A` */
+          def reachableType(symbol: Symbol): Type =
+            if symbol.is(Flags.Package) then
+              ThisType.raw(TypeRef(NoPrefix, symbol.asType))
+            else if symbol.isType then
+              ThisType.raw(TypeRef(reachableType(symbol.owner), symbol.asType))
+            else
+              throw new RuntimeException("unexpected term symbol " + symbol)
+
+          def innerType(symbol: Symbol): Type =
+            TypeRef(reachableType(symbol.owner), symbol)
+
           def processClassType(tp: Type): Type = tp match {
             case tp: TypeRef =>
               if (sig(index) == '<') {
@@ -388,13 +394,13 @@ class ClassfileParser(
           }
 
           val classSym = classNameToSymbol(subName(c => c == ';' || c == '<'))
-          val classTpe = if (classSym eq defn.ObjectClass) defn.FromJavaObjectType else classSym.typeRef
-          var tpe = processClassType(processInner(classTpe))
+          val classTpe = if (classSym eq defn.ObjectClass) defn.FromJavaObjectType else innerType(classSym)
+          var tpe = processClassType(classTpe)
           while (sig(index) == '.') {
             accept('.')
             val name = subName(c => c == ';' || c == '<' || c == '.').toTypeName
             val clazz = tpe.member(name).symbol
-            tpe = processClassType(processInner(TypeRef(tpe, clazz)))
+            tpe = processClassType(innerType(clazz))
           }
           accept(';')
           tpe