Avoid memory leak in TypedSplice (reverted from commit 016c5d7)

odersky · odersky · commit 1d30bd047f8f · 2017-07-18T09:31:24.000+02:00
diff --git a/compiler/src/dotty/tools/dotc/ast/untpd.scala b/compiler/src/dotty/tools/dotc/ast/untpd.scala
@@ -29,10 +29,8 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo {
   }
 
   object TypedSplice {
-    def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice = {
-      val curOwner = ctx.owner // compute here to avoid space leak with a reference from TypedSplice to Context
-      new TypedSplice(tree)(curOwner) {}
-    }
+    def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice =
+      new TypedSplice(tree)(ctx.owner) {}
   }
 
   /** mods object name impl */

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,8 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`object TypedSplice {`
`32`		`- def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice = {`
`33`		`- val curOwner = ctx.owner // compute here to avoid space leak with a reference from TypedSplice to Context`
`34`		`- new TypedSplice(tree)(curOwner) {}`
`35`		`- }`
	`32`	`+ def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice =`
	`33`	`+ new TypedSplice(tree)(ctx.owner) {}`
`36`	`34`	`}`
`37`	`35`
`38`	`36`	`/** mods object name impl */`