Better classification of message kinds

Author: odersky

compiler/src/dotty/tools/dotc/reporting/messages.scala

@@ -28,7 +28,7 @@ import collection.mutable
 import config.Printers.{overload, typr, unapp}
 import TypeApplications._
 
-import reporting.messages.{UnexpectedPatternForSummonFrom, NotAMember, MissingIdent, TypeMismatch}
+import reporting.messages.{UnexpectedPatternForSummonFrom, NotFoundMsg, TypeMismatch}
 import reporting.{trace, Message}
 import Constants.{Constant, IntTag, LongTag}
 import dotty.tools.dotc.reporting.messages.{UnapplyInvalidReturnType, NotAnExtractor, UnapplyInvalidNumberOfArguments}
@@ -1068,10 +1068,7 @@ trait Applications extends Compatibility {
     state.reporter.pendingMessages match
       case msg :: Nil =>
         msg.contained match
-          case msg: NotAMember =>
-            memberName.isEmpty || msg.name == memberName
-          case msg: MissingIdent =>
-            memberName.isEmpty || msg.name == memberName
+          case msg: NotFoundMsg => memberName.isEmpty || msg.name == memberName
           case _ => false
       case _ => false
 

compiler/src/dotty/tools/dotc/typer/Applications.scala

@@ -450,7 +450,7 @@ class Typer extends Namer
         // we are in the arguments of a this(...) constructor call
         errorType(ex"$tree is not accessible from constructor arguments", tree.sourcePos)
       else
-        errorType(new MissingIdent(tree, kind, name), tree.sourcePos)
+        errorType(MissingIdent(tree, kind, name), tree.sourcePos)
 
     val tree1 = ownType match {
       case ownType: NamedType =>