Add workaround issue in phantomArgLift on implicit functions

Author: nicolasstucki

language-server/test/dotty/tools/languageserver/util/actions/Action.scala

@@ -11,4 +11,9 @@ trait Action {
   def execute(): Exec[Unit]
   def show: PosCtx[String]
   def server: Exec[DottyLanguageServer] = implicitly[TestServer].server
+
+  // FIXME
+  // Workaroud an issue with implicit functions and phantomArgLift.
+  // That phase will dispear which should fix this issue. Just remove calls to param when that hapens
+  protected def fix[T](f: PositionContext => T): PosCtx[T] = f(implicitly[PositionContext])
 }

language-server/test/dotty/tools/languageserver/util/actions/CodeDefinition.scala

@@ -6,7 +6,7 @@ import dotty.tools.languageserver.util.embedded.CodeMarker
 class CodeDefinition(val range: CodeRange, refOpt: Option[CodeRange]) extends ActionOnRange {
 
   override def onMarker(marker: CodeMarker): Exec[Unit] = {
-    val res = server.definition(marker.toTextDocumentPositionParams).get()
+    val res = server.definition(fix(marker.toTextDocumentPositionParams)).get()
     assert(res.size() == refOpt.size, res)
     refOpt.foreach(ref => assert(res.get(0) == ref.toLocation, res))
   }

language-server/test/dotty/tools/languageserver/util/actions/CodeDocumentHighlight.scala

@@ -10,7 +10,7 @@ class CodeDocumentHighlight(val range: CodeRange, highs: Seq[(CodeRange, String)
 
   override def onMarker(marker: CodeMarker): Exec[Unit] = {
     val (refs, kinds) = highs.unzip
-    val res = server.documentHighlight(marker.toTextDocumentPositionParams).get()
+    val res = server.documentHighlight(fix(marker.toTextDocumentPositionParams)).get()
     assert(res.size() == refs.size, res)
     assert(refs.size == kinds.length, res)
     res.asScala.zip(refs).zip(kinds).foreach { case ((dhl, ref), kind) =>

language-server/test/dotty/tools/languageserver/util/actions/CodeHover.scala

@@ -3,10 +3,14 @@ package dotty.tools.languageserver.util.actions
 import dotty.tools.languageserver.util.embedded.CodeMarker
 import dotty.tools.languageserver.util.{CodeRange, PositionContext}
 
+import org.eclipse.lsp4j._
+
+import PositionContext._
+
 class CodeHover(val range: CodeRange, expected: String) extends ActionOnRange {
 
   override def onMarker(marker: CodeMarker): Exec[Unit] = {
-    val res = server.hover(marker.toTextDocumentPositionParams).get()
+    val res = server.hover(fix(marker.toTextDocumentPositionParams)).get()
     assert(res.getRange == null)
     if (expected == "") assert(res.getContents == null, "Expected null contents in " + res)
     else {

language-server/test/dotty/tools/languageserver/util/actions/CodeReferences.scala

@@ -8,7 +8,7 @@ import scala.collection.JavaConverters._
 class CodeReferences(val range: CodeRange, refs: List[CodeRange], withDecl: Boolean) extends ActionOnRange {
 
   override def onMarker(marker: CodeMarker): Exec[Unit] = {
-    val res = server.references(marker.toReferenceParams(withDecl)).get()
+    val res = server.references(fix(marker.toReferenceParams(withDecl))).get()
     assert(res.size() == refs.size)
     res.asScala.zip(refs).foreach { case (loc, ref) => assert(loc == ref.toLocation, res) }
   }