Merge pull request #5012 from dotty-staging/fix-4999-pattern-match-byref

Fix #4999: allow pattern matching against by-name arguments

Author: allanrenucci

compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala

@@ -117,7 +117,7 @@ object PatternMatcher {
     /** Widen type as far as necessary so that it does not refer to a pattern-
      *  generated variable.
      */
-    private def sanitize(tp: Type): Type = tp.widenExpr match {
+    private def sanitize(tp: Type): Type = tp.widenIfUnstable match {
       case tp: TermRef if refersToInternal(false, tp) => sanitize(tp.underlying)
       case tp => tp
     }

tests/pos/i4999.scala

@@ -0,0 +1,9 @@
+trait Foo
+final class Bar extends Foo
+
+class Test {
+  def test(xs: => Foo) = xs match {
+    case xs: Bar => 1
+    case _       => 2
+  }
+}