remove var ContextBase.suppressNonSensicalErrors, and

decouple Diagnostic from ContextBase

Author: samuelgruetter

src/dotty/tools/dotc/core/Contexts.scala

@@ -504,9 +504,6 @@ object Contexts {
 
     protected[dotc] val indentTab = "  "
 
-    /** Should warnings and errors containing non-sensical strings be suppressed? */
-    private[dotc] var suppressNonSensicalErrors = true
-
     def reset() = {
       for ((_, set) <- uniqueSets) set.clear()
       for (i <- 0 until classOfId.length) classOfId(i) = null

src/dotty/tools/dotc/reporting/Reporter.scala

@@ -13,7 +13,7 @@ import java.lang.System.currentTimeMillis
 
 object Reporter {
 
-  class Diagnostic(msgFn: => String, val pos: SourcePosition, val severity: Severity, base: ContextBase) extends Exception {
+  class Diagnostic(msgFn: => String, val pos: SourcePosition, val severity: Severity) extends Exception {
     private var myMsg: String = null
     private var myIsSuppressed: Boolean = false
     def msg: String = {
@@ -22,10 +22,7 @@ object Reporter {
         catch {
           case ex: SuppressedMessage =>
             myIsSuppressed = true
-            val saved = base.suppressNonSensicalErrors
-            base.suppressNonSensicalErrors = false
-            try myMsg = msgFn
-            finally base.suppressNonSensicalErrors = saved
+            myMsg = "<suppressed message>"
         }
       myMsg
     }
@@ -38,8 +35,8 @@ object Reporter {
       else severity
   }
 
-  def Diagnostic(msgFn: => String, pos: SourcePosition, severity: Severity)(implicit ctx: Context) =
-    new Diagnostic(msgFn, pos, severity, ctx.base)
+  def Diagnostic(msgFn: => String, pos: SourcePosition, severity: Severity) =
+    new Diagnostic(msgFn, pos, severity)
 
   class Severity(val level: Int) extends AnyVal {
     override def toString = this match {