Repeated params must correspond in override

Refchecks runs after elimRepeated and did not
error on an attempt to override RepeatedParam with
Seq. Also show RepeatedParam in error message.

Author: som-snytt

compiler/src/dotty/tools/dotc/typer/RefChecks.scala

@@ -26,6 +26,7 @@ import scala.util.matching.Regex._
 import Constants.Constant
 import NullOpsDecorator._
 import dotty.tools.dotc.config.Feature
+import scala.PartialFunction.cond
 
 object RefChecks {
   import tpd._
@@ -253,7 +254,7 @@ object RefChecks {
     def infoString(sym: Symbol) = infoString0(sym, sym.owner != clazz)
     def infoStringWithLocation(sym: Symbol) = infoString0(sym, true)
 
-    def infoString0(sym: Symbol, showLocation: Boolean) = {
+    def infoString0(sym: Symbol, showLocation: Boolean) = atPhase(typerPhase) {
       val sym1 = sym.underlyingSymbol
       def info = self.memberInfo(sym1)
       val infoStr =
@@ -265,6 +266,19 @@ object RefChecks {
       i"${if (showLocation) sym1.showLocated else sym1}$infoStr"
     }
 
+    def incompatibleRepeatedParam(member: Symbol, other: Symbol): Boolean =
+      def mismatched(p1: List[Type], p2: List[Type]): Boolean =
+        p1 match
+          case h :: t => cond(p2) { case h2 :: t2 => h.isRepeatedParam != h2.isRepeatedParam || mismatched(t, t2) }
+          case _ => false
+      def loop(ps1: List[List[Type]], ps2: List[List[Type]]): Boolean =
+        ps1 match
+          case h :: t => cond(ps2) { case h2 :: t2 => mismatched(h, h2) || loop(t, t2) }
+          case _ => false
+      member.is(Method, butNot = JavaDefined) && other.is(Method, butNot = JavaDefined) && atPhase(typerPhase) {
+        loop(member.info.paramInfoss, other.info.paramInfoss)
+      }
+
     /* Check that all conditions for overriding `other` by `member`
        * of class `clazz` are met.
        */
@@ -350,10 +364,8 @@ object RefChecks {
       //Console.println(infoString(member) + " overrides " + infoString(other) + " in " + clazz);//DEBUG
 
       /* Is the intersection between given two lists of overridden symbols empty? */
-      def intersectionIsEmpty(syms1: Iterator[Symbol], syms2: Iterator[Symbol]) = {
-        val set2 = syms2.toSet
-        !(syms1 exists (set2 contains _))
-      }
+      def intersectionIsEmpty(syms1: Iterator[Symbol], syms2: Iterator[Symbol]) =
+        !syms1.exists(syms2.toSet.contains)
 
       // o: public | protected        | package-protected  (aka java's default access)
       // ^-may be overridden by member with access privileges-v
@@ -414,6 +426,8 @@ object RefChecks {
               + "\n(Note: this can be resolved by declaring an override in " + clazz + ".)")
         else if member.is(Exported) then
           overrideError("cannot override since it comes from an export")
+        else if incompatibleRepeatedParam(member, other) then
+          overrideError("cannot override because erased signatures conflict in repeated parameter")
         else
           overrideError("needs `override` modifier")
       else if (other.is(AbsOverride) && other.isIncompleteIn(clazz) && !member.is(AbsOverride))
@@ -839,6 +853,7 @@ object RefChecks {
       def isSignatureMatch(sym: Symbol) = sym.isType || {
         val self = clazz.thisType
         sym.asSeenFrom(self).matches(member.asSeenFrom(self))
+        && !incompatibleRepeatedParam(sym, member)
       }
 
       /* The rules for accessing members which have an access boundary are more
@@ -871,8 +886,8 @@ object RefChecks {
     }
 
     // 4. Check that every defined member with an `override` modifier overrides some other member.
-    for (member <- clazz.info.decls)
-      if (member.isAnyOverride && !(clazz.thisType.baseClasses exists (hasMatchingSym(_, member)))) {
+    for member <- clazz.info.decls do
+      if member.isAnyOverride && !clazz.thisType.baseClasses.exists(hasMatchingSym(_, member)) then
         if (checks != noPrinter)
           for (bc <- clazz.info.baseClasses.tail) {
             val sym = bc.info.decl(member.name).symbol
@@ -896,7 +911,7 @@ object RefChecks {
         }
         member.resetFlag(Override)
         member.resetFlag(AbsOverride)
-      }
+      end if
   }
 
   // Note: if a symbol has both @deprecated and @migration annotations and both

tests/neg/override-scala2-macro.check

@@ -1,5 +1,5 @@
 -- [E164] Declaration Error: tests/neg/override-scala2-macro.scala:2:22 ------------------------------------------------
 2 |  override inline def f[A >: Any](args: A*): String = ??? // error
   |                      ^
-  |error overriding method f in class StringContext of type [A >: Any](args: Seq[A]): String;
-  |  method f of type [A >: Any](args: Seq[A]): String cannot be used here - only Scala-2 macros can override Scala-2 macros
+  |error overriding method f in class StringContext of type [A >: Any](args: A*): String;
+  |  method f of type [A >: Any](args: A*): String cannot be used here - only Scala-2 macros can override Scala-2 macros

tests/neg/overrides.scala

@@ -104,3 +104,23 @@ class C extends A {
 }
 }
 
+package p6 {
+  class A { def apply(xs: Int*) = 42 }
+  class B extends A { override def apply(xs: Seq[Int]) = 42 } // error
+}
+package p7 {
+  class A { def apply(xs: Int*) = 42 }
+  class B extends A { def apply(xs: Seq[Int]) = 42 } // error
+}
+package p8 {
+  class A { def apply(xs: Seq[Int]) = 42 }
+  class B extends A { override def apply(xs: Int*) = 42 } // error
+}
+package p9 {
+  class A { def apply(xs: Seq[Int]) = 42 }
+  class B extends A { def apply(xs: Int*) = 42 } // error
+}
+package p10 {
+  class A { def apply(s: String)(xs: Int*) = 42 }
+  class B extends A { def apply(s: String)(xs: Seq[Int]) = 42 } // error
+}