Properly identify empty bounds in error message (#19310)

nicolasstucki · web-flow · commit 0336e686367b · 2023-12-21T11:20:34.000+01:00
This caused a trailing space which can easily misbehave in checkfiles.
diff --git a/compiler/src/dotty/tools/dotc/reporting/Message.scala b/compiler/src/dotty/tools/dotc/reporting/Message.scala
@@ -146,7 +146,7 @@ object Message:
       }
 
       def addendum(cat: String, info: Type): String = info match {
-        case bounds @ TypeBounds(lo, hi) if bounds ne TypeBounds.empty =>
+        case bounds @ TypeBounds(lo, hi) if !(bounds =:= TypeBounds.empty) =>
           if (lo eq hi) i" which is an alias of $lo"
           else i" with $cat ${boundsStr(bounds)}"
         case _ =>
diff --git a/tests/neg/i13780-1.check b/tests/neg/i13780-1.check
@@ -5,7 +5,7 @@
    |                      Required: h
    |
    |                      where:    VS is a type in method foo with bounds <: Tuple
-   |                                h  is a type in method foo with bounds 
+   |                                h  is a type in method foo
    |                                t  is a type in method foo with bounds <: Tuple
    |
    |

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ object Message:`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`def addendum(cat: String, info: Type): String = info match {`
`149`		`- case bounds @ TypeBounds(lo, hi) if bounds ne TypeBounds.empty =>`
	`149`	`+ case bounds @ TypeBounds(lo, hi) if !(bounds =:= TypeBounds.empty) =>`
`150`	`150`	`if (lo eq hi) i" which is an alias of $lo"`
`151`	`151`	`else i" with $cat ${boundsStr(bounds)}"`
`152`	`152`	`case _ =>`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`\| Required: h`
`6`	`6`	`\|`
`7`	`7`	`\| where: VS is a type in method foo with bounds <: Tuple`
`8`		`- \| h is a type in method foo with bounds`
	`8`	`+ \| h is a type in method foo`
`9`	`9`	`\| t is a type in method foo with bounds <: Tuple`
`10`	`10`	`\|`
`11`	`11`	`\|`