Skip to content

Commit 010097f

Browse files
committed
Revert to fix false positive reachability warnings
(cherry picked from commit a11fa3b)
1 parent 7dffdb1 commit 010097f

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

compiler/src/dotty/tools/dotc/transform/patmat/Space.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -953,8 +953,9 @@ class SpaceEngine(using Context) extends SpaceLogic {
953953
if prev == Empty && covered == Empty then // defer until a case is reachable
954954
deferred ::= pat
955955
else {
956-
for (pat <- deferred.reverseIterator)
957-
report.warning(MatchCaseUnreachable(), pat.srcPos)
956+
// FIXME: These should be emitted, but reverted for i13931
957+
//for (pat <- deferred.reverseIterator)
958+
// report.warning(MatchCaseUnreachable(), pat.srcPos)
958959
if pat != EmptyTree // rethrow case of catch uses EmptyTree
959960
&& isSubspace(covered, prev)
960961
then {

tests/patmat/i13485.check

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
11: Match case Unreachable
21
16: Match case Unreachable

tests/patmat/i13485.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ sealed trait Foo
88
class Bar
99

1010
def test1(bar: Bar) = bar match
11-
case _: Foo => 1
11+
case _: Foo => 1 // FIXME: this is unreachable, but reverted for i13931
1212
case _: Bar => 2
1313

1414
def test2(bar: Bar) = bar match

tests/patmat/i13931.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
class Test:
2+
def test = Vector() match
3+
case Seq() => println("empty")
4+
case _ => println("non-empty")

0 commit comments

Comments
 (0)