processArgs is final for some tailrec

Author: som-snytt

compiler/src/dotty/tools/dotc/config/Settings.scala

@@ -221,28 +221,26 @@ object Settings {
      *
      *  to get their arguments.
      */
-    def processArguments(state: ArgsSummary, processAll: Boolean, skipped: List[String]): ArgsSummary = {
+    final def processArguments(state: ArgsSummary, processAll: Boolean, skipped: List[String]): ArgsSummary =
       def stateWithArgs(args: List[String]) = ArgsSummary(state.sstate, args, state.errors, state.warnings)
-      state.arguments match {
+      state.arguments match
         case Nil =>
           checkDependencies(stateWithArgs(skipped))
         case "--" :: args =>
           checkDependencies(stateWithArgs(skipped ++ args))
         case x :: _ if x startsWith "-" =>
-          @tailrec def loop(settings: List[Setting[?]]): ArgsSummary = settings match {
+          @tailrec def loop(settings: List[Setting[?]]): ArgsSummary = settings match
             case setting :: settings1 =>
               val state1 = setting.tryToSet(state)
-              if (state1 ne state) processArguments(state1, processAll, skipped)
+              if state1 ne state then processArguments(state1, processAll, skipped)
               else loop(settings1)
             case Nil =>
               processArguments(state.warn(s"bad option '$x' was ignored"), processAll, skipped)
-          }
           loop(allSettings.toList)
         case arg :: args =>
-          if (processAll) processArguments(stateWithArgs(args), processAll, skipped :+ arg)
+          if processAll then processArguments(stateWithArgs(args), processAll, skipped :+ arg)
           else state
-      }
-    }
+    end processArguments
 
     def processArguments(arguments: List[String], processAll: Boolean, settingsState: SettingsState = defaultState): ArgsSummary =
       processArguments(ArgsSummary(settingsState, arguments, Nil, Nil), processAll, Nil)

compiler/test/dotty/tools/dotc/SettingsTests.scala

@@ -54,6 +54,26 @@ class SettingsTests {
       assertEquals(1, Settings.bar.value)
     }
 
+  @Test def `workaround dont crash on many files`: Unit =
+    object Settings extends SettingGroup
+
+    inContext {
+      val args = "--" :: List.fill(6000)("file.scala")
+      val summary = Settings.processArguments(args, true)
+      assertTrue(summary.errors.isEmpty)
+      assertEquals(6000, summary.arguments.size)
+    }
+
+  @Test def `dont crash on many files`: Unit =
+    object Settings extends SettingGroup
+
+    inContext {
+      val args = List.fill(6000)("file.scala")
+      val summary = Settings.processArguments(args, true)
+      assertTrue(summary.errors.isEmpty)
+      assertEquals(6000, summary.arguments.size)
+    }
+
   @Test def validateChoices: Unit =
     object Settings extends SettingGroup:
       val foo = ChoiceSetting("-foo", "foo", "Foo", List("a", "b"), "a")