From 5abc895bd7842cf2928d136cbfbb155d3728deff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Oliver=20Bra=C4=8Devac?= <bracevac@users.noreply.github.com>
Date: Sun, 2 Mar 2025 22:45:08 +0100
Subject: [PATCH] Repl: emit warning for the `:sh` command

Fixes #21657

[Cherry-picked 9181b5588eae06ff3cfe7a35a415008fbd215bfe]
---
 compiler/src/dotty/tools/repl/ParseResult.scala       | 7 +++++++
 compiler/src/dotty/tools/repl/ReplDriver.scala        | 4 ++++
 compiler/test-resources/repl/i21657                   | 2 ++
 compiler/test/dotty/tools/repl/TabcompleteTests.scala | 1 +
 4 files changed, 14 insertions(+)
 create mode 100644 compiler/test-resources/repl/i21657

diff --git a/compiler/src/dotty/tools/repl/ParseResult.scala b/compiler/src/dotty/tools/repl/ParseResult.scala
index 2674a385a10c..dd4c5d80a9e1 100644
--- a/compiler/src/dotty/tools/repl/ParseResult.scala
+++ b/compiler/src/dotty/tools/repl/ParseResult.scala
@@ -100,6 +100,12 @@ object Reset {
   val command: String = ":reset"
 }
 
+/** `:sh <command line>` run a shell command (result is implicitly => List[String]) */
+case class Sh(expr: String) extends Command
+object Sh {
+  val command: String = ":sh"
+}
+
 /** Toggle automatic printing of results */
 case object Silent extends Command:
   val command: String = ":silent"
@@ -150,6 +156,7 @@ object ParseResult {
     TypeOf.command -> (arg => TypeOf(arg)),
     DocOf.command -> (arg => DocOf(arg)),
     Settings.command -> (arg => Settings(arg)),
+    Sh.command -> (arg => Sh(arg)),
     Silent.command -> (_ => Silent),
   )
 
diff --git a/compiler/src/dotty/tools/repl/ReplDriver.scala b/compiler/src/dotty/tools/repl/ReplDriver.scala
index 282ad86efa32..114fa607f945 100644
--- a/compiler/src/dotty/tools/repl/ReplDriver.scala
+++ b/compiler/src/dotty/tools/repl/ReplDriver.scala
@@ -539,6 +539,10 @@ class ReplDriver(settings: Array[String],
       }
       state
 
+    case Sh(expr) =>
+      out.println(s"""The :sh command is deprecated. Use `import scala.sys.process._` and `"command".!` instead.""")
+      state
+
     case Settings(arg) => arg match
       case "" =>
         given ctx: Context = state.context
diff --git a/compiler/test-resources/repl/i21657 b/compiler/test-resources/repl/i21657
new file mode 100644
index 000000000000..fa2eec3ac891
--- /dev/null
+++ b/compiler/test-resources/repl/i21657
@@ -0,0 +1,2 @@
+scala>:sh
+The :sh command is deprecated. Use `import scala.sys.process._` and `"command".!` instead.
\ No newline at end of file
diff --git a/compiler/test/dotty/tools/repl/TabcompleteTests.scala b/compiler/test/dotty/tools/repl/TabcompleteTests.scala
index 8c817dc2b96f..a881b828ec75 100644
--- a/compiler/test/dotty/tools/repl/TabcompleteTests.scala
+++ b/compiler/test/dotty/tools/repl/TabcompleteTests.scala
@@ -221,6 +221,7 @@ class TabcompleteTests extends ReplTest {
         ":quit",
         ":reset",
         ":settings",
+        ":sh",
         ":silent",
         ":type"
       ),