Merge pull request #314 from scala/backport-lts-3.3-22757

Backport "No warning for parameter of overriding method" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/transform/CheckUnused.scala

@@ -573,6 +573,7 @@ object CheckUnused:
       end checkExplicit
       // begin
       if !infos.skip(m)
+        && !m.nextOverriddenSymbol.exists
         && !allowed
       then
         checkExplicit()

compiler/src/dotty/tools/repl/ReplDriver.scala

@@ -547,7 +547,7 @@ class ReplDriver(settings: Array[String],
         try {
           val entries = flatten(jarFile)
 
-          val existingClass = entries.filter(_.ext.isClass).find(tryClassLoad(_).isDefined)
+          val existingClass = entries.filter(_.extension == "class").find(tryClassLoad(_).isDefined)
           if (existingClass.nonEmpty)
             out.println(s"The path '$path' cannot be loaded, it contains a classfile that already exists on the classpath: ${existingClass.get}")
           else inContext(state.context):

tests/semanticdb/metac.expect

@@ -70,10 +70,10 @@ package foo.test.i16865:
   trait Bar extends Foo
 
   object Ex extends Bar:
-    def fn(a: Int, b: Int): Int = b + 3 // warn
+    def fn(a: Int, b: Int): Int = b + 3 // no warn (override)
 
   object Ex2 extends Bar:
-    override def fn(a: Int, b: Int): Int = b + 3 // warn
+    override def fn(a: Int, b: Int): Int = b + 3 // no warn (override)
 
 final class alpha(externalName: String) extends StaticAnnotation // no warn annotation arg
 

tests/warn/i15503e.scala

@@ -0,0 +1,10 @@
+//> using options -Wunused:all -Werror
+
+trait Foldable[F[_]]:
+  def foldLeft[A, B](fa: F[A], b: B)(f: (B, A) => B): B
+
+type Id[A] = A
+
+given foldableId: Foldable[Id] =
+  new Foldable[Id]:
+    def foldLeft[A, B](fa: Id[A], b: B)(f: (B, A) => B): B = b

tests/warn/i22742.scala

@@ -23,7 +23,7 @@ trait BadAPI extends InterFace {
     a
   }
   override def call(a: Int,
-                    b: String, // warn now
+                    b: String, // no warn (override)
                     c: Double): Int = {
     println(c)
     a

tests/warn/scala2-t11681.scala

@@ -23,7 +23,7 @@ trait BadAPI extends InterFace {
     a
   }
   override def call(a: Int,
-                    b: String, // warn
+                    b: String, // no warn (override)
                     c: Double): Int = {
     println(c)
     a
@@ -136,7 +136,7 @@ trait BadMix { self: InterFace =>
 }
 
 class Unequal {
-  override def equals(other: Any) = toString.nonEmpty   // warn
+  override def equals(other: Any) = toString.nonEmpty   // no warn (override)
 }
 
 class Seriously {