Skip to content

Remove libraryDependency exclude from build #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashawley opened this issue Aug 27, 2019 · 0 comments · Fixed by #512
Closed

Remove libraryDependency exclude from build #346

ashawley opened this issue Aug 27, 2019 · 0 comments · Fixed by #512

Comments

@ashawley
Copy link
Member

ashawley commented Aug 27, 2019

Is this needed any longer?

https://github.com/scala/scala-xml/blob/5dac609d66/build.sbt#L137

Is the scala-compiler dependency an actual dependency? If the point is to avoid getting a redundant scala-xml on the classpath in this build or downstream users, that shouldn't be a problem with sbt 1.2 or later. I know there are compiler and reflection tests, but maybe they can be moved elsewhere or sunset.

If the point is to avoid a redundant scala-xml dependency from the compiler for downstream users, that was fixed in 2.13. It seems it shouldn't be an issue with 2.12, but it would take an investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant