Skip to content

Commit 01e5c50

Browse files
juriskashawley
authored andcommitted
Avoid duplicate getUniversalKey invocation
1 parent 1c6ed32 commit 01e5c50

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

shared/src/main/scala/scala/xml/MetaData.scala

+12-4
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,18 @@ object MetaData {
3737
*/
3838
def normalize(attribs: MetaData, scope: NamespaceBinding): MetaData = {
3939
def iterate(md: MetaData, normalized_attribs: MetaData, set: Set[String]): MetaData = {
40-
def key = getUniversalKey(md, scope)
41-
if (md eq Null) normalized_attribs
42-
else if ((md.value eq null) || set(key)) iterate(md.next, normalized_attribs, set)
43-
else md copy iterate(md.next, normalized_attribs, set + key)
40+
if (md eq Null) {
41+
normalized_attribs
42+
} else if (md.value eq null) {
43+
iterate(md.next, normalized_attribs, set)
44+
} else {
45+
val key = getUniversalKey(md, scope)
46+
if (set(key)) {
47+
iterate(md.next, normalized_attribs, set)
48+
} else {
49+
md copy iterate(md.next, normalized_attribs, set + key)
50+
}
51+
}
4452
}
4553
iterate(attribs, Null, Set())
4654
}

0 commit comments

Comments
 (0)