Skip to content

Commit 794cc74

Browse files
authored
Merge pull request #1605 from mkurz/scala/scala3
Update links to use scala/scala3 in latest blog post
2 parents 91693e8 + ddfa840 commit 794cc74

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

blog/_posts/2024-03-06-scala-3.3.2-post-mortem.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ However, for code readability and performance reasons, the compiler maintains a
5151
When it reads the string `"evidence$"`, it reuses the instance of `NameKind` that it uses for that particular string.
5252

5353
This leads us to the cause of our bug.
54-
Between 3.3.1 and 3.3.2, we merged [PR #18280](https://github.com/lampepfl/dotty/pull/18280).
54+
Between 3.3.1 and 3.3.2, we merged [PR #18280](https://github.com/scala/scala3/pull/18280).
5555
That PR starts with what appeared to be a *refactoring* commit that renamed some `NameKind`s and their associated strings.
5656
Unfortunately, that means the 3.3.2 compiler started emitting `UniqueName`s with the string `"contextual$"`.
5757
When the 3.3.1 compiler reads that structured name, it tries to find the cached instance of `NameKind` that it should use for `"contextual$"`, and does not find any, because it did not use to generate that string.
@@ -63,7 +63,7 @@ In order to fix this in 3.3.3, we reverted to generating `UniqueName("evidence$"
6363
The root cause is that the compiler assumed that only a fixed set of known strings would ever appear in TASTy `UniqueName`s, despite the fact that the TASTy format says that any string is valid in that position.
6464
From that root cause, an unfortunate combination of events happened.
6565

66-
First, when we reviewed [PR #18280](https://github.com/lampepfl/dotty/pull/18280), taking the TASTy format into account, we assumed that using new strings would be a perfectly compatible change.
66+
First, when we reviewed [PR #18280](https://github.com/scala/scala3/pull/18280), taking the TASTy format into account, we assumed that using new strings would be a perfectly compatible change.
6767
We therefore did not mark the PR as "needs-minor-release" as we merged it into the `main` branch for release in 3.4.0.
6868

6969
Second, the PR was backported to the 3.3.x LTS branch.

0 commit comments

Comments
 (0)