[multi-user CI] scabot conf

Needs a `knife vault update master scabot --file /tmp/scabot.json`,
with `/tmp/scabot.json`:
```
{
  "github": {
    "scala": {"token": "..."}
  }
}
```

Author: adriaanm

README.md

@@ -280,7 +280,15 @@ knife vault create master scabot-keypair \
   --admins adriaan
 
 knife vault create master scabot \
-  --json $PWD/.chef/scabot.json \
+  {
+    "jenkins": {
+      "token": "..."
+    },
+    "github": {
+      "scala":    {"token": "..."}
+      "lampepfl": {"token": "..."}
+    }
+  }
   --search 'name:jenkins-master' \
   --admins adriaan
 

attributes/default.rb

@@ -121,6 +121,5 @@
   default['master']['ec2-start-stop']['url'] = 'https://dl.dropboxusercontent.com/u/12862572/ec2-start-stop.hpi'
 
   # SCABOT
-  default['scabot']['jenkins']['user']     = "scala-jenkins"
-  default['scabot']['github']['repo_user'] = "scala"
+  default['scabot']['jenkins']['user'] = "scala-jenkins"
 end

recipes/_master-config-scabot.rb

@@ -59,14 +59,15 @@
   revision   "master"
 end
 
-# TODO: do not use node.set for sensitive stuff!!
-node.set['scabot']['github']['token']  = chef_vault_item("master", "scabot")['github']['token']
-node.set['scabot']['jenkins']['token'] = chef_vault_item("master", "scabot")['jenkins']['token']
-
 template "#{scabotHome}/scabot.conf" do
   source    'scabot.conf.erb'
   user      scabotUser
   sensitive true
+
+  variables({
+    :scabotVault => chef_vault_item("master", "scabot")
+  })
+
 end
 
 bash 'build scabot' do

templates/default/scabot.conf.erb

@@ -1,15 +1,15 @@
 scala: {
   jenkins: {
-    job:   "scala-2.11.x-validate-main"
-    jobPrefix: "scala-2.11.x-" // this will be stripped when reporting to github TODO: remove once it's computed as s"${github.repo}-${pull.base.ref}-"
+    jobSuffix: "validate-main"
     host:  "<%=node['master']['jenkinsHost']%>"
     user:  "<%=node['scabot']['jenkins']['user']%>"
-    token: "<%=node['scabot']['jenkins']['token']%>"
+    token: "<%=@scabotVault['jenkins']['token']%>"
   }
   github: {
-    user:  "<%=node['scabot']['github']['repo_user']%>"
     repo:  "scala"
+    branches: ["2.11.x", "2.12.x"]
     host:  "api.github.com"
-    token: "<%=node['scabot']['github']['token']%>"
+    user:  "scala"
+    token: "<%=@scabotVault['github']['scala']['token']%>"
   }
 }