re-enable doc generation on JDK 11 and on Scala 3

it appears whatever problems we were working around no longer exist?

Author: SethTisue

build.sbt

@@ -1,8 +1,3 @@
-val disableDocs =
-  sys.props("nodocs") == "true" ||
-    // on jdk 11 https://github.com/scala/scala-java8-compat/issues/160, seems to fail the build (not on 8)
-    !sys.props("java.version").startsWith("1.")
-
 lazy val JavaDoc = config("genjavadoc") extend Compile
 
 def jwrite(dir: java.io.File, pck: String = "scala/compat/java8")(name: String, content: String) = {
@@ -102,32 +97,27 @@ lazy val scalaJava8Compat = (project in file("."))
       if (Set("1.5", "1.6", "1.7") contains specVersion)
         sys.error("Java 8 or higher is required for this project.")
     },
-
-    packageDoc / publishArtifact := !disableDocs && !scalaVersion.value.startsWith("3.")
   )
   .settings(
-    inConfig(JavaDoc)(Defaults.configSettings) ++ {
-      if (disableDocs) Nil
-      else Seq(
-        Compile / packageDoc := (JavaDoc / packageDoc).value,
-        JavaDoc / sources := {
-          val allJavaSources =
-            (target.value / "java" ** "*.java").get ++
-              (Compile / sources).value.filter(_.getName.endsWith(".java"))
-          allJavaSources.filterNot(_.getName.contains("FuturesConvertersImpl.java")) // this file triggers bugs in genjavadoc
-        },
-        JavaDoc / javacOptions := Seq("-Xdoclint:none"),
-        JavaDoc / packageDoc / artifactName := ((sv, mod, art) => "" + mod.name + "_" + sv.binary + "-" + mod.revision + "-javadoc.jar"),
-        libraryDependencies ++= (CrossVersion.partialVersion(scalaVersion.value) match {
-          case Some((3, _)) => Seq()
-          case _            => Seq(compilerPlugin("com.typesafe.genjavadoc" % "genjavadoc-plugin" % "0.18" cross CrossVersion.full))
-        }),
-        Compile / scalacOptions ++= (CrossVersion.partialVersion(scalaVersion.value) match {
-          case Some((3, _)) => Seq()
-          case _            => Seq(s"""-P:genjavadoc:out=${target.value / "java"}""")
-        }),
-      )
-    }
+    inConfig(JavaDoc)(Defaults.configSettings) ++ Seq(
+      Compile / packageDoc := (JavaDoc / packageDoc).value,
+      JavaDoc / sources := {
+        val allJavaSources =
+          (target.value / "java" ** "*.java").get ++
+            (Compile / sources).value.filter(_.getName.endsWith(".java"))
+        allJavaSources.filterNot(_.getName.contains("FuturesConvertersImpl.java")) // this file triggers bugs in genjavadoc
+      },
+      JavaDoc / javacOptions := Seq("-Xdoclint:none"),
+      JavaDoc / packageDoc / artifactName := ((sv, mod, art) => "" + mod.name + "_" + sv.binary + "-" + mod.revision + "-javadoc.jar"),
+      libraryDependencies ++= (CrossVersion.partialVersion(scalaVersion.value) match {
+        case Some((3, _)) => Seq()
+        case _            => Seq(compilerPlugin("com.typesafe.genjavadoc" % "genjavadoc-plugin" % "0.18" cross CrossVersion.full))
+      }),
+      Compile / scalacOptions ++= (CrossVersion.partialVersion(scalaVersion.value) match {
+        case Some((3, _)) => Seq()
+        case _            => Seq(s"""-P:genjavadoc:out=${target.value / "java"}""")
+      }),
+    )
   )
   .settings(
     initialCommands :=