Skip to content

Commit 416fe31

Browse files
committed
Merge pull request #46 from retronym/topic/add212
Add Scala 2.12.0-M2 as a cross build
2 parents 31244ba + 8947583 commit 416fe31

File tree

5 files changed

+302
-303
lines changed

5 files changed

+302
-303
lines changed

.travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ env:
1212
script:
1313
- admin/build.sh
1414
scala:
15-
- 2.11.6
15+
- 2.11.7
16+
- 2.12.0-M2
1617
jdk:
1718
- oraclejdk8
1819
notifications:

build.sbt

+4-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ def jwrite(dir: java.io.File)(name: String, content: String) = {
99
}
1010

1111
lazy val commonSettings = Seq(
12-
scalaVersion := "2.11.6",
12+
scalaVersion := "2.11.7",
13+
crossScalaVersions := List("2.11.7", "2.12.0-M2"),
1314
organization := "org.scala-lang.modules",
1415
version := "0.6.0-SNAPSHOT",
1516
libraryDependencies += "org.scala-lang" % "scala-reflect" % scalaVersion.value,
@@ -100,8 +101,8 @@ lazy val root = (project in file(".")).
100101
},
101102
javacOptions in JavaDoc := Seq(),
102103
artifactName in packageDoc in JavaDoc := ((sv, mod, art) => "" + mod.name + "_" + sv.binary + "-" + mod.revision + "-javadoc.jar"),
103-
libraryDependencies += compilerPlugin("com.typesafe.genjavadoc" % "genjavadoc-plugin" % "0.8" cross CrossVersion.full),
104-
scalacOptions in Compile <+= target map (t => "-P:genjavadoc:out=" + (t / "java"))
104+
libraryDependencies += compilerPlugin("com.typesafe.genjavadoc" % "genjavadoc-plugin" % "0.9" cross CrossVersion.full),
105+
scalacOptions in Compile += "-P:genjavadoc:out=" + (target.value / "java")
105106
))): _*
106107
).
107108
settings(

src/main/scala/scala/compat/java8/FutureConverters.scala

+8-2
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,14 @@ object FutureConverters {
7171
* @return a Scala Future that represents the CompletionStage's completion
7272
*/
7373
def toScala[T](cs: CompletionStage[T]): Future[T] = {
74-
val p = new P[T]
75-
cs whenComplete p
74+
val p = Promise[T]()
75+
val bc = new BiConsumer[T, Throwable] {
76+
override def accept(v: T, e: Throwable): Unit = {
77+
if (e == null) p.complete(Success(v))
78+
else p.complete(Failure(e))
79+
}
80+
}
81+
cs whenComplete bc
7682
p.future
7783
}
7884

src/main/scala/scala/concurrent/java8/FutureConvertersImpl.scala

-7
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,4 @@ object FuturesConvertersImpl {
7171

7272
override def toString: String = super[CompletableFuture].toString
7373
}
74-
75-
class P[T] extends impl.Promise.DefaultPromise[T] with BiConsumer[T, Throwable] {
76-
override def accept(v: T, e: Throwable): Unit = {
77-
if (e == null) complete(Success(v))
78-
else complete(Failure(e))
79-
}
80-
}
8174
}

0 commit comments

Comments
 (0)