-
Notifications
You must be signed in to change notification settings - Fork 87
release 2.1.3 #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
though I see now that @lrytz already did a v2.1.3-TEST (commit: 4bb98e7) at https://travis-ci.org/scala/scala-collection-compat/builds/585968641 (history at #252, #255). that's encouraging. regardless, I would like to do an RC, especially since it's my first time doing a module release with the new process |
gah is it sbt/sbt-ci-release#64 ? we see at 600dba3 that Lukas believed the problem to be fixed as of sbt-scala-module 2.1.2 |
my bedtime is approaching. @lrytz perhaps you could take a look if you're not too busy, since you've been over this ground before. otherwise I'll come back to it myself (I am no longer underwater, I have a decent amount of time this week and next) |
Hmm :-( Comparing to the test release, sbt was upgraded from 1.3.0 to 1.3.4. Maybe that broke the workaround sbt/sbt-ci-release#66? I'll do some testing with https://github.com/lrytz/travis-test. |
Ah, also in the travis log: The good version has:
The bad one:
So it's indeed the workaround that's missing. |
travis-test worked. but i just saw now that this repository doesn't use the |
Tagged an v2.1.3-RC2, and the builds look fine: https://travis-ci.org/scala/scala-collection-compat/builds/623598336 |
@lrytz I just wanted to let you know that the Travis file looks super good. I wish somehow we could use a Travis file like that with This is my solution using Stages - https://github.com/ekrich/sconfig/blob/topic/sjs10rc1/.travis.yml If we could figure out how to use This would make a formula that anyone could copy and tweak and make this publishing easy and fast. cc/ @SethTisue Even @tpolecat would be happy. |
@ekrich the In other modules, we use a pretty standard build.sbt and travis.yml, and the build script actually invokes Is this what you're looking for? |
@lrytz I am not looking particularly but this was something discussed on different chats about how hard publishing is to do. |
I just hit "release" on the staging repos, so the 2.1.3-RC2 artifacts should reach Maven Central before long. @ekrich please let us know whether the Scala.js 1.0.0-RC1 artifacts work for you |
(before doing 2.1.3 final we'll also want to make sure that artifacts show up at https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-migrations_2.12/2.1.3/) |
they didn't. pursuing that at #279 |
Tried RC3 after #281, and while sonatype seems to have some issues right now (getting timeouts, https://travis-ci.org/scala/scala-collection-compat/builds/624058691), at least there seems to be an additional 2.12.8 staging repo, which is promising. |
I re-ran the failed jobs and this resulted in some additional staging repositories. And I see scala-collection-migrations artifacts now. I released all the staging repositories just now; once everything hits Maven Central I'll do one last round of sanity checking, then go back and re-tag as 2.1.3 final. |
FYI in the meantime we published the artifacts for Scala.js 1.0.0-RC2. The announcement should be up tomorrow. |
The 2.1.3-RC3 artifacts on Maven Central are okay afaict, and on Gitter, @ekrich said he'd tried the 2.1.3-RC2 artifact with Scala.js 1.0.0-RC1 and had trouble, but didn't think the trouble was because the artifact was bad. And, I merged #278, so we can publish for Scala.js 1.0.0-RC2 instead of RC1. I'll go ahead with publishing 2.1.3 shortly. After my nap 💤 |
The RC2 worked fine once I worked out the Scala.js issues. Thanks, looking forward to the new version. |
(yawns, stretches, puts on a cup of tea) okay, where were we?
what a pleasure to be off our bespoke module publishing stuff and on sbt-ci-release instead! thank you @lrytz @olafurpg, and thank you @xerial and @ekrich for the cross-platform help |
gah, now what, 2.1.3-RC3 is missing from https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.12/ and 2.1.3 isn't showing up either 😡 digging... everything seems normal at https://travis-ci.org/scala/scala-collection-compat/jobs/624349130 @lrytz I am mystified. do you have any idea what could have gone wrong here? |
Was just going to comment that I couldn't find JVM 2.12 version. |
since I don't see any clues, I guess we should just try again, although given that this somehow went wrong for 2.1.3-RC3 as well, I'm pessimistic I re-ran https://travis-ci.org/scala/scala-collection-compat/jobs/624349130 (for possible later tea-leaf-reading, the log from the previous run is at https://gist.github.com/SethTisue/1839a531648df75606055e981613cd6f) new staging repo is orgscala-lang-2033 released the staging repo 🤞 |
yay it worked even though nothing was different |
Uh oh!
There was an error while loading. Please reload this page.
for two reasons:
this will be the first time we release this module with sbt-ci-release instead of the old module releasing process, so I'm half expecting it will go wrong. and there are some ways in which it might go wrong that would still involve scala-steward jumping on it before you can say "holy runaway automation, Batman"
so I'd like to do a 2.1.3-RC1 first, see if everything publishes, and have Eric verify that the artifacts are usable with Scala.js 1.0.0-RC1. if that all goes well, I'll follow up with a proper 2.1.3 release
(2.1.2 release ticket was #214)
The text was updated successfully, but these errors were encountered: