Skip to content

release 2.1.3 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Dec 11, 2019 · 23 comments
Closed

release 2.1.3 #276

SethTisue opened this issue Dec 11, 2019 · 23 comments

Comments

@SethTisue
Copy link
Member

SethTisue commented Dec 11, 2019

for two reasons:

this will be the first time we release this module with sbt-ci-release instead of the old module releasing process, so I'm half expecting it will go wrong. and there are some ways in which it might go wrong that would still involve scala-steward jumping on it before you can say "holy runaway automation, Batman"

so I'd like to do a 2.1.3-RC1 first, see if everything publishes, and have Eric verify that the artifacts are usable with Scala.js 1.0.0-RC1. if that all goes well, I'll follow up with a proper 2.1.3 release

(2.1.2 release ticket was #214)

@SethTisue
Copy link
Member Author

SethTisue commented Dec 11, 2019

this will be the first time we release this module with sbt-ci-release instead of the old module releasing process, so I'm half expecting it will go wrong

though I see now that @lrytz already did a v2.1.3-TEST (commit: 4bb98e7) at https://travis-ci.org/scala/scala-collection-compat/builds/585968641 (history at #252, #255). that's encouraging. regardless, I would like to do an RC, especially since it's my first time doing a module release with the new process

@SethTisue
Copy link
Member Author

SethTisue commented Dec 11, 2019

gah [error] java.io.FileNotFoundException: /home/travis/.sbt/gpg/secring.asc (No such file or directory)

is it sbt/sbt-ci-release#64 ?

we see at 600dba3 that Lukas believed the problem to be fixed as of sbt-scala-module 2.1.2

@SethTisue
Copy link
Member Author

SethTisue commented Dec 11, 2019

my bedtime is approaching. @lrytz perhaps you could take a look if you're not too busy, since you've been over this ground before. otherwise I'll come back to it myself (I am no longer underwater, I have a decent amount of time this week and next)

@lrytz
Copy link
Member

lrytz commented Dec 11, 2019

Hmm :-(

Comparing to the test release, sbt was upgraded from 1.3.0 to 1.3.4. Maybe that broke the workaround sbt/sbt-ci-release#66?

I'll do some testing with https://github.com/lrytz/travis-test.

@lrytz
Copy link
Member

lrytz commented Dec 11, 2019

Ah, also in the travis log:

The good version has:

Running CI: 
compat211/clean
compat211/test
compat211/publishLocal
set pgpSecretRing := pgpSecretRing.value
set pgpPublicRing := pgpPublicRing.value
compat211/publishSigned
sonatypePrepare
sonatypeBundleUpload
sonatypeClose

The bad one:

Running CI: 
compat211/clean
compat211/test
compat211/publishLocal
compat211/publishSigned
sonatypePrepare
sonatypeBundleUpload
sonatypeClose

So it's indeed the workaround that's missing.

@lrytz
Copy link
Member

lrytz commented Dec 11, 2019

travis-test worked. but i just saw now that this repository doesn't use the ci-release task, but replicates its implementation to some degree (https://github.com/scala/scala-collection-compat/blob/master/build.sbt#L348-L359). So the workaround removed in 600dba3#diff-fdc3abdfd754eeb24090dbd90aeec2ce actually needs to stay. It seems I never tested it after removing it... Sorry!

@lrytz
Copy link
Member

lrytz commented Dec 11, 2019

Tagged an v2.1.3-RC2, and the builds look fine: https://travis-ci.org/scala/scala-collection-compat/builds/623598336

I left the staging repos in place, here's a screenshot:
image

@ekrich
Copy link
Contributor

ekrich commented Dec 11, 2019

@lrytz I just wanted to let you know that the Travis file looks super good. I wish somehow we could use a Travis file like that with sbt-ci-release out of the box but sbt-ci-release uses Travis Stages in its example.

This is my solution using Stages - https://github.com/ekrich/sconfig/blob/topic/sjs10rc1/.travis.yml
As you can see, it is not elegant.

If we could figure out how to use sbt-ci-release with a Travis file like yours in an idiomatic way without the extra code in the sbt file we could make everyone's life easier.

This would make a formula that anyone could copy and tweak and make this publishing easy and fast. cc/ @SethTisue

Even @tpolecat would be happy.

@lrytz
Copy link
Member

lrytz commented Dec 11, 2019

@ekrich the build.sbt file in this repo is rather complicated for reasons I'm not aware. I just did the minimal change to get ci-release working with it the way I want.

In other modules, we use a pretty standard build.sbt and travis.yml, and the build script actually invokes sbt ci-release. See https://github.com/scala/scala-collection-contrib for example. We're not using build stages.

Is this what you're looking for?

@ekrich
Copy link
Contributor

ekrich commented Dec 11, 2019

@lrytz I am not looking particularly but this was something discussed on different chats about how hard publishing is to do. sbt-ci-release really helps but doing a matrix with stages in Travis is unclear to me and it seems that many projects have glue in the sbt or a build.sh or the like. I am referring to sbt-ci-release which is a godsend to many of us - https://github.com/olafurpg/sbt-ci-release

@SethTisue
Copy link
Member Author

I just hit "release" on the staging repos, so the 2.1.3-RC2 artifacts should reach Maven Central before long. @ekrich please let us know whether the Scala.js 1.0.0-RC1 artifacts work for you

@SethTisue
Copy link
Member Author

(before doing 2.1.3 final we'll also want to make sure that artifacts show up at https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-migrations_2.12/2.1.3/)

@SethTisue
Copy link
Member Author

SethTisue commented Dec 12, 2019

(before doing 2.1.3 final we'll also want to make sure that artifacts show up at https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-migrations_2.12/)

they didn't. pursuing that at #279

@lrytz
Copy link
Member

lrytz commented Dec 12, 2019

Tried RC3 after #281, and while sonatype seems to have some issues right now (getting timeouts, https://travis-ci.org/scala/scala-collection-compat/builds/624058691), at least there seems to be an additional 2.12.8 staging repo, which is promising.

@SethTisue
Copy link
Member Author

I re-ran the failed jobs and this resulted in some additional staging repositories. And I see scala-collection-migrations artifacts now. I released all the staging repositories just now; once everything hits Maven Central I'll do one last round of sanity checking, then go back and re-tag as 2.1.3 final.

@sjrd
Copy link
Member

sjrd commented Dec 12, 2019

FYI in the meantime we published the artifacts for Scala.js 1.0.0-RC2. The announcement should be up tomorrow.

@SethTisue
Copy link
Member Author

SethTisue commented Dec 12, 2019

The 2.1.3-RC3 artifacts on Maven Central are okay afaict, and on Gitter, @ekrich said he'd tried the 2.1.3-RC2 artifact with Scala.js 1.0.0-RC1 and had trouble, but didn't think the trouble was because the artifact was bad.

And, I merged #278, so we can publish for Scala.js 1.0.0-RC2 instead of RC1.

I'll go ahead with publishing 2.1.3 shortly. After my nap 💤

@ekrich
Copy link
Contributor

ekrich commented Dec 12, 2019

The RC2 worked fine once I worked out the Scala.js issues. Thanks, looking forward to the new version.

@SethTisue
Copy link
Member Author

SethTisue commented Dec 12, 2019

(yawns, stretches, puts on a cup of tea)

okay, where were we?

what a pleasure to be off our bespoke module publishing stuff and on sbt-ci-release instead! thank you @lrytz @olafurpg, and thank you @xerial and @ekrich for the cross-platform help

@SethTisue
Copy link
Member Author

SethTisue commented Dec 12, 2019

gah, now what, 2.1.3-RC3 is missing from https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.12/ and 2.1.3 isn't showing up either 😡

digging...

everything seems normal at https://travis-ci.org/scala/scala-collection-compat/jobs/624349130

@lrytz I am mystified. do you have any idea what could have gone wrong here?

@ekrich
Copy link
Contributor

ekrich commented Dec 12, 2019

Was just going to comment that I couldn't find JVM 2.12 version.

@SethTisue
Copy link
Member Author

since I don't see any clues, I guess we should just try again, although given that this somehow went wrong for 2.1.3-RC3 as well, I'm pessimistic

I re-ran https://travis-ci.org/scala/scala-collection-compat/jobs/624349130 (for possible later tea-leaf-reading, the log from the previous run is at https://gist.github.com/SethTisue/1839a531648df75606055e981613cd6f)

new staging repo is orgscala-lang-2033

released the staging repo

🤞

@SethTisue
Copy link
Member Author

yay it worked even though nothing was different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants