Rewrite breakOut for Future.{sequence, traverse} (fix #93)

Author: MasseGuillaume

scalafix/input/src/main/scala/fix/BreakoutSrc.scala

@@ -5,7 +5,6 @@ package fix
 
 import scala.collection.breakOut
 import scala.collection.{immutable, mutable}
-
 import scala.concurrent.Future
 import scala.concurrent.ExecutionContext.Implicits.global
 
@@ -87,7 +86,6 @@ class BreakoutSrc(ts: Traversable[Int], vec: Vector[Int], list: List[Int], seq:
   // `Vector.updated`
   (vec.updated(0, 0))(breakOut): List[Int]
 
-  // TODO
-  // Future.sequence(List(Future(1)))(breakOut, global): Future[Seq[Int]]
-  // Future.traverse(List(1))(x => Future(x))(breakOut, global): Future[Seq[Int]]
+  Future.sequence(List(Future(1)))(breakOut, global): Future[Seq[Int]]
+  Future.traverse(List(1))(x => Future(x))(breakOut, global): Future[Seq[Int]]
 }

scalafix/output212/src/main/scala/fix/BreakoutSrc.scala

@@ -4,7 +4,6 @@
 package fix
 
 import scala.collection.{immutable, mutable}
-
 import scala.concurrent.Future
 import scala.concurrent.ExecutionContext.Implicits.global
 import scala.collection.compat._
@@ -87,7 +86,6 @@ class BreakoutSrc(ts: Iterable[Int], vec: Vector[Int], list: List[Int], seq: Seq
   // `Vector.updated`
   (vec.view.updated(0, 0)).to(scala.collection.immutable.List): List[Int]
 
-  // TODO
-  // Future.sequence(List(Future(1)))(breakOut, global): Future[Seq[Int]]
-  // Future.traverse(List(1))(x => Future(x))(breakOut, global): Future[Seq[Int]]
+  Future.sequence(List(Future(1)))(scala.collection.immutable.List, global): Future[Seq[Int]]
+  Future.traverse(List(1))(x => Future(x))(scala.collection.immutable.List, global): Future[Seq[Int]]
 }

scalafix/rules/src/main/scala/fix/Stable212Base.scala

@@ -138,6 +138,9 @@ trait Stable212Base extends CrossCompatibility { self: SemanticRule =>
         case Term.Name(value) => value.last != ':'
         case _ => false
       }
+
+    val `Future.sequence` = SymbolMatcher.exact(Symbol("_root_.scala.concurrent.Future.sequence(Lscala/collection/TraversableOnce;Lscala/collection/generic/CanBuildFrom;Lscala/concurrent/ExecutionContext;)Lscala/concurrent/Future;."))
+    val `Future.traverse` = SymbolMatcher.exact(Symbol("_root_.scala.concurrent.Future.traverse(Lscala/collection/TraversableOnce;Lscala/Function1;Lscala/collection/generic/CanBuildFrom;Lscala/concurrent/ExecutionContext;)Lscala/concurrent/Future;."))
   }
 
 
@@ -188,6 +191,11 @@ trait Stable212Base extends CrossCompatibility { self: SemanticRule =>
       sharedPatch + toColl
     }
 
+    def fixFuture(breakout: Tree): Patch = {
+      val toCollection = extractColFromBreakout(breakout).syntax
+      ctx.replaceTree(breakout, toCollection)
+    }
+
     def extractColFromBreakout(breakout: Tree): Term = {
       val synth = ctx.index.synthetics.find(_.position.end == breakout.pos.end).get
       val Term.Apply(_, List(implicitCbf)) = synth.text.parse[Term].get
@@ -260,6 +268,14 @@ trait Stable212Base extends CrossCompatibility { self: SemanticRule =>
         case ap0 @ Term.Apply(ap @ Term.Apply(Term.Apply(Term.Select(lhs, `TraversableLike.scanLeft`(op)), _), _), List(breakOut(bo))) =>
           fixIt("iterator", lhs, ap, bo, ap0)
 
+        // sequence(xs)(breakOut, ec)
+        case Term.Apply(Term.Apply(`Future.sequence`(_), _), List(breakOut(bo), _)) =>
+          fixFuture(bo)
+
+        // traverse(xs)(f)(breakOut, ec)
+        case Term.Apply(Term.Apply(Term.Apply(`Future.traverse`(_),_), _), List(breakOut(bo), _)) =>
+          fixFuture(bo)
+
         case i: Importee if breakOut.matches(i) =>
           breakOutImports += i
           Patch.empty