Skip to content

Commit 57f0ab0

Browse files
committed
Add a test to check that Factory is binary-compatible
1 parent 0436b16 commit 57f0ab0

File tree

3 files changed

+27
-4
lines changed

3 files changed

+27
-4
lines changed
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
11
package org.example
22

3-
object Lib
3+
import scala.collection.generic._
4+
import scala.collection.compat._
5+
6+
object Lib {
7+
def id[A, C[X] <: Iterable[X]](x: C[A])(implicit factory: Factory[A, C[A]]) = {
8+
val builder = factory.newBuilder
9+
builder ++= x
10+
builder.result
11+
}
12+
13+
def test1 =
14+
id(List(1, 2, 3))
15+
}
Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
11
package org.example
22

3-
object Lib
3+
import scala.collection.generic._
4+
5+
object Lib {
6+
def id[A, C[X] <: Iterable[X]](x: C[A])(implicit cbf: CanBuildFrom[C[A], A, C[A]]) = {
7+
val builder = cbf()
8+
builder ++= x
9+
builder.result
10+
}
11+
12+
def test1 =
13+
id(List(1, 2, 3))
14+
}

binary-compat/test/src/test/scala/BinaryCompaTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ class BinaryCompaTest {
1111
Config.setup("foo", Array(oldClasspath, newClasspath))
1212
val mima = new MiMaLib(Config.baseClassPath)
1313
val allProblems = mima.collectProblems(oldClasspath, newClasspath)
14-
Assert.assertTrue(allProblems.isEmpty)
14+
Assert.assertEquals(allProblems, Nil)
1515
}
16-
}
16+
}

0 commit comments

Comments
 (0)