Skip to content

Deleted pages are not removed from the website #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienrf opened this issue Nov 2, 2022 · 4 comments
Closed

Deleted pages are not removed from the website #2621

julienrf opened this issue Nov 2, 2022 · 4 comments
Assignees

Comments

@julienrf
Copy link
Contributor

julienrf commented Nov 2, 2022

For some reason the deleted page https://docs.scala-lang.org/overviews/core/actors-migration-guide.html is still here. It seems that the script that pulls the new website content does not remove deleted pages.

Originally posted by @julienrf in #2542 (comment)

@julienrf
Copy link
Contributor Author

julienrf commented Nov 2, 2022

@fsalvi could you please have a look? A page has been removed in #2604 but it is still on the website: https://docs.scala-lang.org/overviews/core/actors-migration-guide.html

@fsalvi
Copy link
Contributor

fsalvi commented Nov 3, 2022

By default, the script doesn't delete files but only update them to avoid the worst case where a random problem could lead to an empty site (but that can be changed in 2 seconds if needed).
I forced it manually.
Usually, the standard policy is more to replace deleted pages with redirects (using redirect_to) to avoid external links to the scala website returning a 404 error.

@fsalvi fsalvi closed this as completed Nov 3, 2022
@julienrf
Copy link
Contributor Author

julienrf commented Nov 3, 2022

Thank you Fabien, I see that the removed pages are effectively not available anymore on the server. However, that revealed that we had some dead links, as shown by the CI failure: https://github.com/scala/docs.scala-lang/actions/runs/3386648392/jobs/5626321883

@julienrf
Copy link
Contributor Author

julienrf commented Nov 3, 2022

I am fixing the links in #2624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants