Skip to content

Empty table of contents on the glossary page #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lorenzpahl opened this issue Oct 16, 2022 · 2 comments · Fixed by #2608
Closed

Empty table of contents on the glossary page #2607

lorenzpahl opened this issue Oct 16, 2022 · 2 comments · Fixed by #2608

Comments

@lorenzpahl
Copy link
Contributor

The sidebar with the table of contents (TOC) on the glossary page is currently empty. This is due to a change made by commit b88401f (PR #1861). There, h4 elements were excluded from the TOC. I think the easiest way to fix this would be to render the glossary terms using the h3 element instead of h4.

@bishabosha
Copy link
Member

Thanks for opening! I agree because I guess other pages will start adding too many levels of toc

@bishabosha
Copy link
Member

looks like the search box functionality also depends on titles being h4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants