Skip to content

Fix front matter of zh-cn translation of scala 3 book #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bishabosha opened this issue Sep 23, 2022 · 4 comments · Fixed by #2663
Closed

Fix front matter of zh-cn translation of scala 3 book #2559

bishabosha opened this issue Sep 23, 2022 · 4 comments · Fixed by #2663

Comments

@bishabosha
Copy link
Member

bishabosha commented Sep 23, 2022

e.g. https://docs.scala-lang.org/zh-cn/overviews/scala3-book/why-scala-3.html

without the front matter, the pages all have the wrong url, and have no layout applied

Edit: they still need the language field in order to have the language dropdown

@bishabosha bishabosha assigned bishabosha and unassigned bishabosha Sep 23, 2022
@bishabosha
Copy link
Member Author

bishabosha commented Sep 26, 2022

@benluo - just pointing to this issue if you still want to do that

@benluo
Copy link
Contributor

benluo commented Dec 9, 2022

I think it has been solved. I suggest to close the issue.

@bishabosha
Copy link
Member Author

they are still wrong because they do not have the language field, so the language drop down does not appear

@benluo
Copy link
Contributor

benluo commented Dec 31, 2022

I add languages in all files in scala3-book. But they does not pass compile. How should I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants