Skip to content

different versions on the example of libraryDependencies #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcelo-rosa opened this issue Apr 3, 2020 · 3 comments · Fixed by #1694
Closed

different versions on the example of libraryDependencies #1676

marcelo-rosa opened this issue Apr 3, 2020 · 3 comments · Fixed by #1694

Comments

@marcelo-rosa
Copy link

Reading the page

https://docs.scala-lang.org/overviews/scala-book/sbt-scalatest-tdd.html

I saw a conflict in the proposed example in the section Creating the build.sbt file

libraryDependencies ++= Seq(
    "org.scalactic" %% "scalactic" % "3.0.8",
    "org.scalatest" %% "scalatest" % "3.0.8" % "test"
)

and

libraryDependencies ++= Seq(
    "org.scalactic" %% "scalactic" % "3.0.4",
    "org.scalatest" %% "scalatest" % "3.0.4" % "test"
)

I suggest unifying the presented versions so people (like me) that are learning Scala does not get confused about versions 3.0.4 and 3.0.8 in this example. Just pick one of them.

@SethTisue
Copy link
Member

yes, a pull request correcting this would be welcome

@SethTisue
Copy link
Member

SethTisue commented Apr 17, 2020

incidentally the scalactic dependency isn't necessary, I don't think we should be recommending it to language newcomers. in the test configuration, it's a transitive dependency of scalatest. in the compile configuration, sure it's possible that someone would want to use it, but I think it's really better to recommend the standard, minimum thing which is a single dependency in the test config.

% "test" should be changed to % Test. either will work, but the latter is a little nicer

@SethTisue
Copy link
Member

PR: #1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants