Skip to content

Commit 56d37e5

Browse files
committed
Add pull request links
1 parent 1360686 commit 56d37e5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

_sips/sips/2018-08-20-converters-among-optional-functions-partialfunctions-and-extractor-objects.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ val csvRow: String => Option[Seq[String]] = { line =>
7272

7373
## Implementation
7474

75-
The `extract` method has been implemented in a library: [Extractor.scala](https://github.com/ThoughtWorksInc/Extractor.scala), which has been used in Binding.scala in order to [extract patterns of XML literals](https://github.com/ThoughtWorksInc/Binding.scala/blob/10.0.x/XmlExtractor/src/main/scala/com/thoughtworks/binding/XmlExtractor.scala#L63).
75+
The `extract` method was originally implemented in a library: [Extractor.scala](https://github.com/ThoughtWorksInc/Extractor.scala), which has been used in Binding.scala in order to [extract patterns of XML literals](https://github.com/ThoughtWorksInc/Binding.scala/blob/10.0.x/XmlExtractor/src/main/scala/com/thoughtworks/binding/XmlExtractor.scala#L63).
76+
77+
The new implementation aims to become part of core library. The pull request can be found at [#7111][2].
7678

7779
## Drawbacks
7880

@@ -82,5 +84,7 @@ process anyway so it's better to get them out up front.
8284
## References
8385

8486
1. [Existing Implementation (Extractor.scala)][1]
87+
2. [Related Pull Request][2]
8588

8689
[1]: https://github.com/ThoughtWorksInc/Extractor.scala "Extractor.scala"
90+
[2]: https://github.com/scala/scala/pull/7111 "#7111"

0 commit comments

Comments
 (0)