Skip to content

Commit ee06906

Browse files
authored
Merge pull request #41 from adam-singer/adam-singer/clean-up-imports-and-paths
Clean up imports and benchmark NPE exception on path
2 parents e12e46f + cb05f43 commit ee06906

File tree

6 files changed

+21
-38
lines changed

6 files changed

+21
-38
lines changed

compilation/src/main/scala/scala/tools/nsc/HotSbtBenchmark.scala

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
package scala.tools.nsc
22

33
import java.io._
4-
import java.net.URL
54
import java.nio.file._
6-
import java.nio.file.attribute.BasicFileAttributes
75
import java.util.concurrent.TimeUnit
86

9-
import com.typesafe.config.ConfigFactory
107
import org.openjdk.jmh.annotations.Mode.SampleTime
118
import org.openjdk.jmh.annotations._
129

13-
import scala.collection.JavaConverters._
14-
1510
@State(Scope.Benchmark)
1611
@BenchmarkMode(Array(SampleTime))
1712
@OutputTimeUnit(TimeUnit.MILLISECONDS)
@@ -166,4 +161,4 @@ class HotSbtBenchmark {
166161
BenchmarkUtils.deleteRecursive(tempDir)
167162
BenchmarkUtils.deleteRecursive(scalaHome)
168163
}
169-
}
164+
}

compilation/src/main/scala/scala/tools/nsc/JavacBenchmark.java

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,16 @@
11
package scala.tools.nsc;
22

3-
import org.openjdk.jmh.annotations.Benchmark;
4-
import org.openjdk.jmh.annotations.Scope;
5-
import org.openjdk.jmh.annotations.Setup;
6-
import org.openjdk.jmh.annotations.State;
7-
8-
import javax.tools.JavaCompiler;
9-
import javax.tools.ToolProvider;
10-
import java.io.File;
11-
import java.io.FileWriter;
123
import java.io.IOException;
13-
import java.net.URL;
14-
import java.net.URLClassLoader;
154
import java.nio.charset.Charset;
165
import java.nio.file.Files;
176
import java.nio.file.Path;
18-
import java.nio.file.Paths;
7+
import javax.tools.JavaCompiler;
8+
import javax.tools.ToolProvider;
9+
10+
import org.openjdk.jmh.annotations.Benchmark;
11+
import org.openjdk.jmh.annotations.Scope;
12+
import org.openjdk.jmh.annotations.Setup;
13+
import org.openjdk.jmh.annotations.State;
1914

2015
@State(Scope.Thread)
2116
public class JavacBenchmark {

compilation/src/main/scala/scala/tools/nsc/ScalacBenchmark.scala

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
package scala.tools.nsc
22

3-
import java.io.{File, IOException}
4-
import java.net.URL
3+
import java.io.File
54
import java.nio.file._
6-
import java.nio.file.attribute.BasicFileAttributes
75
import java.util.concurrent.TimeUnit
86
import java.util.stream.Collectors
97

10-
import com.typesafe.config.ConfigFactory
118
import org.openjdk.jmh.annotations.Mode._
129
import org.openjdk.jmh.annotations._
1310

14-
import scala.collection.JavaConverters._
1511
import scala.tools.benchmark.BenchmarkDriver
1612

1713
trait BaseBenchmarkDriver {

infrastructure/src/main/java/scala/bench/Database.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
11
package scala.bench;
22

3-
import com.typesafe.config.Config;
4-
import com.typesafe.config.ConfigFactory;
5-
import okhttp3.Credentials;
6-
import okhttp3.HttpUrl;
7-
import okhttp3.OkHttpClient;
8-
import org.eclipse.jgit.api.errors.GitAPIException;
9-
import org.eclipse.jgit.lib.Repository;
10-
import org.eclipse.jgit.storage.file.FileRepositoryBuilder;
11-
import org.influxdb.InfluxDB;
12-
import org.influxdb.InfluxDBFactory;
13-
143
import java.io.IOException;
154
import java.net.URI;
165
import java.net.URISyntaxException;
176
import java.nio.file.Files;
18-
import java.nio.file.Path;
197
import java.nio.file.Paths;
20-
import java.util.Arrays;
218
import java.util.stream.Stream;
229

10+
import com.typesafe.config.Config;
11+
import com.typesafe.config.ConfigFactory;
12+
13+
import org.influxdb.InfluxDB;
14+
import org.influxdb.InfluxDBFactory;
15+
16+
import okhttp3.Credentials;
17+
import okhttp3.HttpUrl;
18+
import okhttp3.OkHttpClient;
19+
2320
public class Database {
2421

2522
public static InfluxDB connectDb() {

micro/src/main/scala/scala/tools/nsc/TreeTransformerBenchmark.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class TreeTransformerBenchmark {
1717
var g: Global = _
1818
var tree: Global#Tree = _
1919

20-
@Param(Array("../corpus/vector/Vector.scala"))
20+
@Param(Array("../corpus/vector/latest/Vector.scala"))
2121
var file: String = _
2222

2323
@Setup def setup(): Unit = {

micro/src/main/scala/scala/tools/nsc/TreeTraverserBenchmark.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import scala.reflect.internal.util.BatchSourceFile
1616
class TreeTraverserBenchmark {
1717
var g: Global = _
1818
var tree: Global#Tree = _
19-
@Param(Array("../corpus/vector/Vector.scala"))
19+
@Param(Array("../corpus/vector/latest/Vector.scala"))
2020
var file: String = _
2121

2222
@Setup def setup(): Unit = {

0 commit comments

Comments
 (0)