From 5ec3de295436e145bd4df849fc170a83cceeb203 Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Sun, 8 Aug 2021 12:25:00 +0000 Subject: [PATCH 1/2] Enable MiMa --- .github/workflows/ci.yml | 2 ++ build.sbt | 7 +++++++ project/build.sbt | 2 ++ 3 files changed, 11 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index be20134b1..8ac7c9939 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,6 +27,8 @@ jobs: run: sbt "++${{ matrix.scalaversion }}" example/compile - name: scalafmt run: sbt "++${{ matrix.scalaversion }}" scalafmtCheck + - name: mima + run: sbt "++${{ matrix.scalaversion }}" mimaReportBinaryIssues readme: runs-on: ubuntu-latest steps: diff --git a/build.sbt b/build.sbt index d6a4cc3a6..044a49946 100644 --- a/build.sbt +++ b/build.sbt @@ -54,6 +54,13 @@ scalacOptions ++= { else Nil } +import com.typesafe.tools.mima.core._ +mimaPreviousArtifacts := Set("org.scala-js" %%% "scalajs-dom" % "1.1.0") +mimaBinaryIssueFilters ++= Seq( + // #427 SharedWorker onconnect has wrong type + ProblemFilters.exclude[Problem]("org.scalajs.dom.experimental.sharedworkers.SharedWorkerGlobalScope.onconnect*") +) + scmInfo := Some(ScmInfo( url("https://github.com/scala-js/scala-js-dom"), "scm:git:git@github.com:scala-js/scala-js-dom.git", diff --git a/project/build.sbt b/project/build.sbt index 91d1d968a..29a065bd3 100644 --- a/project/build.sbt +++ b/project/build.sbt @@ -6,3 +6,5 @@ addSbtPlugin("org.scala-js" % "sbt-scalajs" % scalaJSVersion) addSbtPlugin("com.lihaoyi" % "scalatex-sbt-plugin" % "0.3.11") addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.0.0") + +addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.2") From 119e3c6a667959be6e96b78bf9766a407acaee78 Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Sun, 8 Aug 2021 12:46:01 +0000 Subject: [PATCH 2/2] Disable MiMa for Scala 3 --- build.sbt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 044a49946..f77d38750 100644 --- a/build.sbt +++ b/build.sbt @@ -55,7 +55,12 @@ scalacOptions ++= { } import com.typesafe.tools.mima.core._ -mimaPreviousArtifacts := Set("org.scala-js" %%% "scalajs-dom" % "1.1.0") +mimaPreviousArtifacts := { + if (scalaVersion.value.startsWith("3")) + Set.empty + else + Set("org.scala-js" %%% "scalajs-dom" % "1.1.0") +} mimaBinaryIssueFilters ++= Seq( // #427 SharedWorker onconnect has wrong type ProblemFilters.exclude[Problem]("org.scalajs.dom.experimental.sharedworkers.SharedWorkerGlobalScope.onconnect*")