Skip to content

Missing companion objects #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armanbilge opened this issue Oct 18, 2021 · 1 comment · Fixed by #605
Closed

Missing companion objects #604

armanbilge opened this issue Oct 18, 2021 · 1 comment · Fixed by #605
Labels
bug

Comments

@armanbilge
Copy link
Member

armanbilge commented Oct 18, 2021 •
edited
Loading

The companion objects for ResponseInit and experimental.serviceworker.ServiceWorkerGlobalScope seem to have gone missing, possibly more...

Came up while working on http4s/http4s-dom#23.
@armanbilge armanbilge added the bug label Oct 18, 2021
@armanbilge
Copy link
Member Author

Update: ResponseInit was correctly removed from dom, it should only exist in the deprecated packages. Loss of ServiceWorkerGlobalScope I think is my screw up in a migration PR 😆

@armanbilge armanbilge mentioned this issue Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back SharedWorkerGlobalScope to deprecated package scala-js/scala-js-dom
1 participant
@armanbilge