-
Notifications
You must be signed in to change notification settings - Fork 161
prePR
doesn't generate reports on master
#524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oops! |
Hehe. I think you disabled it cos of Scala 3. Gonna have to find a temporary workaround I think... |
We can just add a scala version check I think. |
Wait, maybe I did something stupid in #512 and deleted every line with "delete if scala 2.10" when what I should have done is delete the comment and otherwise leave alone. |
Yeah I was just having a look at scalacenter/scalafix#1316 and it seems Scalafix still doesn't support Scala 3. I could've sworn a read a few weeks ago that it does now. Edit: now I'm seeing some PRs that indicate that it might be supported after all, looking in to it atm.... |
The sbt plugin supports scala 3 I think, but the core module was not published for scala3 which is why I snuck a |
So is there a way to use it on Scala 3 builds? I'm a bit confused |
I restored |
@japgolly this is what spits out:
|
Problems:
We're just gonna have to disable scalafix all together for Scala 3 in a way that
|
I think that's doable, I'm on it in #525. |
Gotta add
(root / Compile / scalafix).toTask("")
back inThe text was updated successfully, but these errors were encountered: