Skip to content

Commit d3633f1

Browse files
armanbilgearmanbilge
committed
Use overloads instead
1 parent 8668b20 commit d3633f1

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

‎api-reports/2_13.txt

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,8 +1724,12 @@ Document[JC] def createAttributeNS(namespaceURI: String, qualifiedName: String):
17241724
Document[JC] def createCDATASection(data: String): CDATASection
17251725
Document[JC] def createComment(data: String): Comment
17261726
Document[JC] def createDocumentFragment(): DocumentFragment
1727-
Document[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
1728-
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
1727+
Document[JC] def createElement(tagName: String): Element
1728+
Document[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
1729+
Document[JC] def createElement(tagName: String, options: String): Element
1730+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
1731+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
1732+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
17291733
Document[JC] def createEvent(eventInterface: String): Event
17301734
Document[JC] def createNSResolver(node: Node): XPathNSResolver
17311735
Document[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator
@@ -4902,8 +4906,12 @@ HTMLDocument[JC] def createAttributeNS(namespaceURI: String, qualifiedName: Stri
49024906
HTMLDocument[JC] def createCDATASection(data: String): CDATASection
49034907
HTMLDocument[JC] def createComment(data: String): Comment
49044908
HTMLDocument[JC] def createDocumentFragment(): DocumentFragment
4905-
HTMLDocument[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
4906-
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
4909+
HTMLDocument[JC] def createElement(tagName: String): Element
4910+
HTMLDocument[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
4911+
HTMLDocument[JC] def createElement(tagName: String, options: String): Element
4912+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
4913+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
4914+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
49074915
HTMLDocument[JC] def createEvent(eventInterface: String): Event
49084916
HTMLDocument[JC] def createNSResolver(node: Node): XPathNSResolver
49094917
HTMLDocument[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator

‎dom/src/main/scala/org/scalajs/dom/Document.scala

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package org.scalajs.dom
88

99
import scala.scalajs.js
1010
import scala.scalajs.js.annotation._
11-
import scala.scalajs.js.|
1211

1312
/** Each web page loaded in the browser has its own document object. The Document interface serves as an entry point to
1413
* the web page's content (the DOM tree, including elements such as <body> and <table>) and provides
@@ -126,12 +125,17 @@ abstract class Document extends Node with NodeSelector with DocumentEvent with P
126125
* document creates the specified XUL element. In other documents creates an element with a null namespaceURI.
127126
*/
128127
def createElement(tagName: String): Element = js.native
128+
129129
def createElement(tagName: String, options: String): Element = js.native
130+
130131
def createElement(tagName: String, options: ElementCreationOptions): Element = js.native
131132

132133
/** Creates an element with the specified namespace URI and qualified name. */
133-
def createElementNS(namespaceURI: String, qualifiedName: String,
134-
options: String | ElementCreationOptions = js.native): Element = js.native
134+
def createElementNS(namespaceURI: String, qualifiedName: String): Element = js.native
135+
136+
def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element = js.native
137+
138+
def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element = js.native
135139

136140
/** createAttribute creates a new attribute node, and returns it. */
137141
def createAttribute(name: String): Attr = js.native

0 commit comments

Comments
 (0)