Skip to content

Commit d157768

Browse files
authored
Merge pull request #788 from alfonso-landin/create-element-options
Add `options` parameter to `Document#createElement`
2 parents 8e7387e + 33f2db2 commit d157768

File tree

4 files changed

+33
-0
lines changed

4 files changed

+33
-0
lines changed

api-reports/2_12.txt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,7 +1725,11 @@ Document[JC] def createCDATASection(data: String): CDATASection
17251725
Document[JC] def createComment(data: String): Comment
17261726
Document[JC] def createDocumentFragment(): DocumentFragment
17271727
Document[JC] def createElement(tagName: String): Element
1728+
Document[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
1729+
Document[JC] def createElement(tagName: String, options: String): Element
17281730
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
1731+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
1732+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
17291733
Document[JC] def createEvent(eventInterface: String): Event
17301734
Document[JC] def createNSResolver(node: Node): XPathNSResolver
17311735
Document[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator
@@ -2065,6 +2069,7 @@ Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
20652069
Element[JC] def shadowRoot: ShadowRoot
20662070
Element[JC] def tagName: String
20672071
Element[JC] var textContent: String
2072+
ElementCreationOptions[JT] var is: js.UndefOr[String]
20682073
ElementDefinitionOptions[JT] var `extends`: js.UndefOr[String]
20692074
EndOfStreamError[JT]
20702075
EndOfStreamError[SO] val decode: EndOfStreamError
@@ -4902,7 +4907,11 @@ HTMLDocument[JC] def createCDATASection(data: String): CDATASection
49024907
HTMLDocument[JC] def createComment(data: String): Comment
49034908
HTMLDocument[JC] def createDocumentFragment(): DocumentFragment
49044909
HTMLDocument[JC] def createElement(tagName: String): Element
4910+
HTMLDocument[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
4911+
HTMLDocument[JC] def createElement(tagName: String, options: String): Element
49054912
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
4913+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
4914+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
49064915
HTMLDocument[JC] def createEvent(eventInterface: String): Event
49074916
HTMLDocument[JC] def createNSResolver(node: Node): XPathNSResolver
49084917
HTMLDocument[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator

api-reports/2_13.txt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,7 +1725,11 @@ Document[JC] def createCDATASection(data: String): CDATASection
17251725
Document[JC] def createComment(data: String): Comment
17261726
Document[JC] def createDocumentFragment(): DocumentFragment
17271727
Document[JC] def createElement(tagName: String): Element
1728+
Document[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
1729+
Document[JC] def createElement(tagName: String, options: String): Element
17281730
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
1731+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
1732+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
17291733
Document[JC] def createEvent(eventInterface: String): Event
17301734
Document[JC] def createNSResolver(node: Node): XPathNSResolver
17311735
Document[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator
@@ -2065,6 +2069,7 @@ Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
20652069
Element[JC] def shadowRoot: ShadowRoot
20662070
Element[JC] def tagName: String
20672071
Element[JC] var textContent: String
2072+
ElementCreationOptions[JT] var is: js.UndefOr[String]
20682073
ElementDefinitionOptions[JT] var `extends`: js.UndefOr[String]
20692074
EndOfStreamError[JT]
20702075
EndOfStreamError[SO] val decode: EndOfStreamError
@@ -4902,7 +4907,11 @@ HTMLDocument[JC] def createCDATASection(data: String): CDATASection
49024907
HTMLDocument[JC] def createComment(data: String): Comment
49034908
HTMLDocument[JC] def createDocumentFragment(): DocumentFragment
49044909
HTMLDocument[JC] def createElement(tagName: String): Element
4910+
HTMLDocument[JC] def createElement(tagName: String, options: ElementCreationOptions): Element
4911+
HTMLDocument[JC] def createElement(tagName: String, options: String): Element
49054912
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
4913+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element
4914+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element
49064915
HTMLDocument[JC] def createEvent(eventInterface: String): Event
49074916
HTMLDocument[JC] def createNSResolver(node: Node): XPathNSResolver
49084917
HTMLDocument[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator

dom/src/main/scala/org/scalajs/dom/Document.scala

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,17 @@ abstract class Document extends Node with NodeSelector with DocumentEvent with P
126126
*/
127127
def createElement(tagName: String): Element = js.native
128128

129+
def createElement(tagName: String, options: String): Element = js.native
130+
131+
def createElement(tagName: String, options: ElementCreationOptions): Element = js.native
132+
129133
/** Creates an element with the specified namespace URI and qualified name. */
130134
def createElementNS(namespaceURI: String, qualifiedName: String): Element = js.native
131135

136+
def createElementNS(namespaceURI: String, qualifiedName: String, options: String): Element = js.native
137+
138+
def createElementNS(namespaceURI: String, qualifiedName: String, options: ElementCreationOptions): Element = js.native
139+
132140
/** createAttribute creates a new attribute node, and returns it. */
133141
def createAttribute(name: String): Attr = js.native
134142

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
trait ElementCreationOptions extends js.Object {
6+
var is: js.UndefOr[String] = js.undefined
7+
}

0 commit comments

Comments
 (0)