Skip to content

Commit a483793

Browse files
japgollyjapgolly
committed
Address PR feedback
1 parent a4338b2 commit a483793

File tree

4 files changed

+36
-36
lines changed

4 files changed

+36
-36
lines changed

‎api-reports/2_12.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ experimental/mediastream/AudioTrackList[JT] def addEventListener[T <: Event](`ty
586586
experimental/mediastream/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
587587
experimental/mediastream/AudioTrackList[JT] @JSBracketAccess def apply(index: Double): AudioTrack
588588
experimental/mediastream/AudioTrackList[JT] def dispatchEvent(evt: Event): Boolean
589-
experimental/mediastream/AudioTrackList[JT] def getTrackById(id: String): js.UndefOr[AudioTrack]
589+
experimental/mediastream/AudioTrackList[JT] def getTrackById(id: String): AudioTrack
590590
experimental/mediastream/AudioTrackList[JT] def length: Double
591591
experimental/mediastream/AudioTrackList[JT] var onaddtrack: js.Function1[Event, Any]
592592
experimental/mediastream/AudioTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -614,7 +614,7 @@ experimental/mediastream/MediaDevices[JT] def removeEventListener[T <: Event](`t
614614
experimental/mediastream/MediaSource[JC] def activeSourceBuffers: SourceBufferList
615615
experimental/mediastream/MediaSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
616616
experimental/mediastream/MediaSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
617-
experimental/mediastream/MediaSource[JC] def addSourceBuffer(bufferType: String): SourceBuffer
617+
experimental/mediastream/MediaSource[JC] def addSourceBuffer(mimeType: String): SourceBuffer
618618
experimental/mediastream/MediaSource[JC] def clearLiveSeekableRange(): Unit
619619
experimental/mediastream/MediaSource[JC] def dispatchEvent(evt: Event): Boolean
620620
experimental/mediastream/MediaSource[JC] var duration: Double
@@ -778,11 +778,11 @@ experimental/mediastream/SourceBufferList[JT] var onaddsourcebuffer: js.Function
778778
experimental/mediastream/SourceBufferList[JT] var onremovesourcebuffer: js.Function1[Event, Any]
779779
experimental/mediastream/SourceBufferList[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
780780
experimental/mediastream/SourceBufferList[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
781-
experimental/mediastream/TextTrack[JT] def activeCues: js.UndefOr[TextTrackCueList]
781+
experimental/mediastream/TextTrack[JT] def activeCues: TextTrackCueList
782782
experimental/mediastream/TextTrack[JT] def addCue(cue: TextTrackCue): Unit
783783
experimental/mediastream/TextTrack[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
784784
experimental/mediastream/TextTrack[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
785-
experimental/mediastream/TextTrack[JT] def cues: js.UndefOr[TextTrackCueList]
785+
experimental/mediastream/TextTrack[JT] def cues: TextTrackCueList
786786
experimental/mediastream/TextTrack[JT] def dispatchEvent(evt: Event): Boolean
787787
experimental/mediastream/TextTrack[JT] val id: String
788788
experimental/mediastream/TextTrack[JT] val inBandMetadataTrackDispatchType: String
@@ -805,15 +805,15 @@ experimental/mediastream/TextTrackCue[JT] var pauseOnExit: Boolean
805805
experimental/mediastream/TextTrackCue[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
806806
experimental/mediastream/TextTrackCue[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
807807
experimental/mediastream/TextTrackCue[JT] var startTime: Double
808-
experimental/mediastream/TextTrackCue[JT] def track: js.UndefOr[TextTrack]
808+
experimental/mediastream/TextTrackCue[JT] def track: TextTrack
809809
experimental/mediastream/TextTrackCueList[JT] @JSBracketAccess def apply(index: Double): TextTrackCue
810-
experimental/mediastream/TextTrackCueList[JT] def getCueById(id: String): js.UndefOr[TextTrackCue]
810+
experimental/mediastream/TextTrackCueList[JT] def getCueById(id: String): TextTrackCue
811811
experimental/mediastream/TextTrackCueList[JT] def length: Double
812812
experimental/mediastream/TextTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
813813
experimental/mediastream/TextTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
814814
experimental/mediastream/TextTrackList[JT] @JSBracketAccess def apply(index: Double): VideoTrack
815815
experimental/mediastream/TextTrackList[JT] def dispatchEvent(evt: Event): Boolean
816-
experimental/mediastream/TextTrackList[JT] def getTrackById(id: String): js.UndefOr[TextTrack]
816+
experimental/mediastream/TextTrackList[JT] def getTrackById(id: String): TextTrack
817817
experimental/mediastream/TextTrackList[JT] def length: Double
818818
experimental/mediastream/TextTrackList[JT] var onaddtrack: js.Function1[Event, Any]
819819
experimental/mediastream/TextTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -829,7 +829,7 @@ experimental/mediastream/VideoTrackList[JT] def addEventListener[T <: Event](`ty
829829
experimental/mediastream/VideoTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
830830
experimental/mediastream/VideoTrackList[JT] @JSBracketAccess def apply(index: Double): VideoTrack
831831
experimental/mediastream/VideoTrackList[JT] def dispatchEvent(evt: Event): Boolean
832-
experimental/mediastream/VideoTrackList[JT] def getTrackById(id: String): js.UndefOr[VideoTrack]
832+
experimental/mediastream/VideoTrackList[JT] def getTrackById(id: String): VideoTrack
833833
experimental/mediastream/VideoTrackList[JT] def length: Double
834834
experimental/mediastream/VideoTrackList[JT] var onaddtrack: js.Function1[Event, Any]
835835
experimental/mediastream/VideoTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -2484,10 +2484,10 @@ raw/AudioParam[JT] def setValueAtTime(value: Double, startTime: Double): Unit
24842484
raw/AudioParam[JT] def setValueCurveAtTime(values: js.typedarray.Float32Array, startTime: Double, duration: Double): Unit
24852485
raw/AudioParam[JT] var value: Double
24862486
raw/AudioTrack[JT] var enabled: Boolean
2487-
raw/AudioTrack[JT] var id: String
2488-
raw/AudioTrack[JT] var kind: String
2489-
raw/AudioTrack[JT] var label: String
2490-
raw/AudioTrack[JT] var language: String
2487+
raw/AudioTrack[JT] val id: String
2488+
raw/AudioTrack[JT] val kind: String
2489+
raw/AudioTrack[JT] val label: String
2490+
raw/AudioTrack[JT] val language: String
24912491
raw/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
24922492
raw/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
24932493
raw/AudioTrackList[JT] @scala.scalajs.js.annotation.JSBracketAccess def apply(index: Int): T

‎api-reports/2_13.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ experimental/mediastream/AudioTrackList[JT] def addEventListener[T <: Event](`ty
586586
experimental/mediastream/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
587587
experimental/mediastream/AudioTrackList[JT] @JSBracketAccess def apply(index: Double): AudioTrack
588588
experimental/mediastream/AudioTrackList[JT] def dispatchEvent(evt: Event): Boolean
589-
experimental/mediastream/AudioTrackList[JT] def getTrackById(id: String): js.UndefOr[AudioTrack]
589+
experimental/mediastream/AudioTrackList[JT] def getTrackById(id: String): AudioTrack
590590
experimental/mediastream/AudioTrackList[JT] def length: Double
591591
experimental/mediastream/AudioTrackList[JT] var onaddtrack: js.Function1[Event, Any]
592592
experimental/mediastream/AudioTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -614,7 +614,7 @@ experimental/mediastream/MediaDevices[JT] def removeEventListener[T <: Event](`t
614614
experimental/mediastream/MediaSource[JC] def activeSourceBuffers: SourceBufferList
615615
experimental/mediastream/MediaSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
616616
experimental/mediastream/MediaSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
617-
experimental/mediastream/MediaSource[JC] def addSourceBuffer(bufferType: String): SourceBuffer
617+
experimental/mediastream/MediaSource[JC] def addSourceBuffer(mimeType: String): SourceBuffer
618618
experimental/mediastream/MediaSource[JC] def clearLiveSeekableRange(): Unit
619619
experimental/mediastream/MediaSource[JC] def dispatchEvent(evt: Event): Boolean
620620
experimental/mediastream/MediaSource[JC] var duration: Double
@@ -778,11 +778,11 @@ experimental/mediastream/SourceBufferList[JT] var onaddsourcebuffer: js.Function
778778
experimental/mediastream/SourceBufferList[JT] var onremovesourcebuffer: js.Function1[Event, Any]
779779
experimental/mediastream/SourceBufferList[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
780780
experimental/mediastream/SourceBufferList[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
781-
experimental/mediastream/TextTrack[JT] def activeCues: js.UndefOr[TextTrackCueList]
781+
experimental/mediastream/TextTrack[JT] def activeCues: TextTrackCueList
782782
experimental/mediastream/TextTrack[JT] def addCue(cue: TextTrackCue): Unit
783783
experimental/mediastream/TextTrack[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
784784
experimental/mediastream/TextTrack[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
785-
experimental/mediastream/TextTrack[JT] def cues: js.UndefOr[TextTrackCueList]
785+
experimental/mediastream/TextTrack[JT] def cues: TextTrackCueList
786786
experimental/mediastream/TextTrack[JT] def dispatchEvent(evt: Event): Boolean
787787
experimental/mediastream/TextTrack[JT] val id: String
788788
experimental/mediastream/TextTrack[JT] val inBandMetadataTrackDispatchType: String
@@ -805,15 +805,15 @@ experimental/mediastream/TextTrackCue[JT] var pauseOnExit: Boolean
805805
experimental/mediastream/TextTrackCue[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
806806
experimental/mediastream/TextTrackCue[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
807807
experimental/mediastream/TextTrackCue[JT] var startTime: Double
808-
experimental/mediastream/TextTrackCue[JT] def track: js.UndefOr[TextTrack]
808+
experimental/mediastream/TextTrackCue[JT] def track: TextTrack
809809
experimental/mediastream/TextTrackCueList[JT] @JSBracketAccess def apply(index: Double): TextTrackCue
810-
experimental/mediastream/TextTrackCueList[JT] def getCueById(id: String): js.UndefOr[TextTrackCue]
810+
experimental/mediastream/TextTrackCueList[JT] def getCueById(id: String): TextTrackCue
811811
experimental/mediastream/TextTrackCueList[JT] def length: Double
812812
experimental/mediastream/TextTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
813813
experimental/mediastream/TextTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
814814
experimental/mediastream/TextTrackList[JT] @JSBracketAccess def apply(index: Double): VideoTrack
815815
experimental/mediastream/TextTrackList[JT] def dispatchEvent(evt: Event): Boolean
816-
experimental/mediastream/TextTrackList[JT] def getTrackById(id: String): js.UndefOr[TextTrack]
816+
experimental/mediastream/TextTrackList[JT] def getTrackById(id: String): TextTrack
817817
experimental/mediastream/TextTrackList[JT] def length: Double
818818
experimental/mediastream/TextTrackList[JT] var onaddtrack: js.Function1[Event, Any]
819819
experimental/mediastream/TextTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -829,7 +829,7 @@ experimental/mediastream/VideoTrackList[JT] def addEventListener[T <: Event](`ty
829829
experimental/mediastream/VideoTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
830830
experimental/mediastream/VideoTrackList[JT] @JSBracketAccess def apply(index: Double): VideoTrack
831831
experimental/mediastream/VideoTrackList[JT] def dispatchEvent(evt: Event): Boolean
832-
experimental/mediastream/VideoTrackList[JT] def getTrackById(id: String): js.UndefOr[VideoTrack]
832+
experimental/mediastream/VideoTrackList[JT] def getTrackById(id: String): VideoTrack
833833
experimental/mediastream/VideoTrackList[JT] def length: Double
834834
experimental/mediastream/VideoTrackList[JT] var onaddtrack: js.Function1[Event, Any]
835835
experimental/mediastream/VideoTrackList[JT] var onchange: js.Function1[Event, Any]
@@ -2484,10 +2484,10 @@ raw/AudioParam[JT] def setValueAtTime(value: Double, startTime: Double): Unit
24842484
raw/AudioParam[JT] def setValueCurveAtTime(values: js.typedarray.Float32Array, startTime: Double, duration: Double): Unit
24852485
raw/AudioParam[JT] var value: Double
24862486
raw/AudioTrack[JT] var enabled: Boolean
2487-
raw/AudioTrack[JT] var id: String
2488-
raw/AudioTrack[JT] var kind: String
2489-
raw/AudioTrack[JT] var label: String
2490-
raw/AudioTrack[JT] var language: String
2487+
raw/AudioTrack[JT] val id: String
2488+
raw/AudioTrack[JT] val kind: String
2489+
raw/AudioTrack[JT] val label: String
2490+
raw/AudioTrack[JT] val language: String
24912491
raw/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
24922492
raw/AudioTrackList[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
24932493
raw/AudioTrackList[JT] @scala.scalajs.js.annotation.JSBracketAccess def apply(index: Int): T

‎src/main/scala/org/scalajs/dom/experimental/mediastream/MediaStream.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ class MediaSource extends EventTarget {
650650
var onsourceended: js.Function1[Event, Any] = js.native
651651
var onsourceclose: js.Function1[Event, Any] = js.native
652652

653-
def addSourceBuffer(bufferType: String): SourceBuffer = js.native
653+
def addSourceBuffer(mimeType: String): SourceBuffer = js.native
654654
def removeSourceBuffer(sourceBuffer: SourceBuffer): Unit = js.native
655655
def endOfStream(error: EndOfStreamError = js.native): Unit = js.native
656656
def setLiveSeekableRange(start: Double, end: Double): Unit = js.native
@@ -707,7 +707,7 @@ trait AudioTrackList extends EventTarget {
707707
@JSBracketAccess
708708
def apply(index: Double): AudioTrack = js.native
709709

710-
def getTrackById(id: String): js.UndefOr[AudioTrack] = js.native
710+
def getTrackById(id: String): AudioTrack = js.native
711711

712712
var onchange: js.Function1[Event, Any] = js.native
713713
var onaddtrack: js.Function1[Event, Any] = js.native
@@ -730,7 +730,7 @@ trait VideoTrackList extends EventTarget {
730730
@JSBracketAccess
731731
def apply(index: Double): VideoTrack = js.native
732732

733-
def getTrackById(id: String): js.UndefOr[VideoTrack] = js.native
733+
def getTrackById(id: String): VideoTrack = js.native
734734

735735
def selectedIndex: Double = js.native
736736

@@ -756,7 +756,7 @@ trait TextTrackList extends EventTarget {
756756
@JSBracketAccess
757757
def apply(index: Double): VideoTrack = js.native
758758

759-
def getTrackById(id: String): js.UndefOr[TextTrack] = js.native;
759+
def getTrackById(id: String): TextTrack = js.native
760760

761761
var onchange: js.Function1[Event, Any] = js.native
762762
var onaddtrack: js.Function1[Event, Any] = js.native
@@ -773,8 +773,8 @@ trait TextTrack extends EventTarget {
773773

774774
var mode: TextTrackMode = js.native
775775

776-
def cues: js.UndefOr[TextTrackCueList] = js.native
777-
def activeCues: js.UndefOr[TextTrackCueList] = js.native
776+
def cues: TextTrackCueList = js.native
777+
def activeCues: TextTrackCueList = js.native
778778

779779
def addCue(cue: TextTrackCue): Unit = js.native
780780
def removeCue(cue: TextTrackCue): Unit = js.native
@@ -789,12 +789,12 @@ trait TextTrackCueList extends js.Object {
789789
@JSBracketAccess
790790
def apply(index: Double): TextTrackCue = js.native
791791

792-
def getCueById(id: String): js.UndefOr[TextTrackCue] = js.native;
792+
def getCueById(id: String): TextTrackCue = js.native
793793
}
794794

795795
@js.native
796796
trait TextTrackCue extends EventTarget {
797-
def track: js.UndefOr[TextTrack] = js.native
797+
def track: TextTrack = js.native
798798

799799
var id: String = js.native
800800
var startTime: Double = js.native

‎src/main/scala/org/scalajs/dom/raw/lib.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7401,10 +7401,10 @@ trait WindowConsole extends js.Object {
74017401

74027402
@js.native
74037403
trait AudioTrack extends js.Object {
7404-
var kind: String = js.native
7405-
var language: String = js.native
7406-
var id: String = js.native
7407-
var label: String = js.native
7404+
val id: String = js.native
7405+
val kind: String = js.native
7406+
val label: String = js.native
7407+
val language: String = js.native
74087408
var enabled: Boolean = js.native
74097409
}
74107410

0 commit comments

Comments
 (0)