Skip to content

Commit 9c623c6

Browse files
Add options parameter to Document#createElement
Also to Document#createElementNS
1 parent f644d7a commit 9c623c6

File tree

4 files changed

+21
-10
lines changed

4 files changed

+21
-10
lines changed

api-reports/2_12.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,8 +1724,8 @@ Document[JC] def createAttributeNS(namespaceURI: String, qualifiedName: String):
17241724
Document[JC] def createCDATASection(data: String): CDATASection
17251725
Document[JC] def createComment(data: String): Comment
17261726
Document[JC] def createDocumentFragment(): DocumentFragment
1727-
Document[JC] def createElement(tagName: String): Element
1728-
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
1727+
Document[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
1728+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
17291729
Document[JC] def createEvent(eventInterface: String): Event
17301730
Document[JC] def createNSResolver(node: Node): XPathNSResolver
17311731
Document[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator
@@ -2065,6 +2065,7 @@ Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
20652065
Element[JC] def shadowRoot: ShadowRoot
20662066
Element[JC] def tagName: String
20672067
Element[JC] var textContent: String
2068+
ElementCreationOptions[JT] var is: js.UndefOr[String]
20682069
ElementDefinitionOptions[JT] var `extends`: js.UndefOr[String]
20692070
EndOfStreamError[JT]
20702071
EndOfStreamError[SO] val decode: EndOfStreamError
@@ -4901,8 +4902,8 @@ HTMLDocument[JC] def createAttributeNS(namespaceURI: String, qualifiedName: Stri
49014902
HTMLDocument[JC] def createCDATASection(data: String): CDATASection
49024903
HTMLDocument[JC] def createComment(data: String): Comment
49034904
HTMLDocument[JC] def createDocumentFragment(): DocumentFragment
4904-
HTMLDocument[JC] def createElement(tagName: String): Element
4905-
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
4905+
HTMLDocument[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
4906+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
49064907
HTMLDocument[JC] def createEvent(eventInterface: String): Event
49074908
HTMLDocument[JC] def createNSResolver(node: Node): XPathNSResolver
49084909
HTMLDocument[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator

api-reports/2_13.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,8 +1724,8 @@ Document[JC] def createAttributeNS(namespaceURI: String, qualifiedName: String):
17241724
Document[JC] def createCDATASection(data: String): CDATASection
17251725
Document[JC] def createComment(data: String): Comment
17261726
Document[JC] def createDocumentFragment(): DocumentFragment
1727-
Document[JC] def createElement(tagName: String): Element
1728-
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
1727+
Document[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
1728+
Document[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
17291729
Document[JC] def createEvent(eventInterface: String): Event
17301730
Document[JC] def createNSResolver(node: Node): XPathNSResolver
17311731
Document[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator
@@ -2065,6 +2065,7 @@ Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
20652065
Element[JC] def shadowRoot: ShadowRoot
20662066
Element[JC] def tagName: String
20672067
Element[JC] var textContent: String
2068+
ElementCreationOptions[JT] var is: js.UndefOr[String]
20682069
ElementDefinitionOptions[JT] var `extends`: js.UndefOr[String]
20692070
EndOfStreamError[JT]
20702071
EndOfStreamError[SO] val decode: EndOfStreamError
@@ -4901,8 +4902,8 @@ HTMLDocument[JC] def createAttributeNS(namespaceURI: String, qualifiedName: Stri
49014902
HTMLDocument[JC] def createCDATASection(data: String): CDATASection
49024903
HTMLDocument[JC] def createComment(data: String): Comment
49034904
HTMLDocument[JC] def createDocumentFragment(): DocumentFragment
4904-
HTMLDocument[JC] def createElement(tagName: String): Element
4905-
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String): Element
4905+
HTMLDocument[JC] def createElement(tagName: String, options: String | ElementCreationOptions?): Element
4906+
HTMLDocument[JC] def createElementNS(namespaceURI: String, qualifiedName: String, options: String | ElementCreationOptions?): Element
49064907
HTMLDocument[JC] def createEvent(eventInterface: String): Event
49074908
HTMLDocument[JC] def createNSResolver(node: Node): XPathNSResolver
49084909
HTMLDocument[JC] def createNodeIterator(root: Node, whatToShow: Int, filter: NodeFilter, entityReferenceExpansion: Boolean): NodeIterator

dom/src/main/scala/org/scalajs/dom/Document.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ package org.scalajs.dom
88

99
import scala.scalajs.js
1010
import scala.scalajs.js.annotation._
11+
import scala.scalajs.js.|
1112

1213
/** Each web page loaded in the browser has its own document object. The Document interface serves as an entry point to
1314
* the web page's content (the DOM tree, including elements such as <body> and <table>) and provides
@@ -124,10 +125,11 @@ abstract class Document extends Node with NodeSelector with DocumentEvent with P
124125
/** In an HTML document creates the specified HTML element or HTMLUnknownElement if the element is not known. In a XUL
125126
* document creates the specified XUL element. In other documents creates an element with a null namespaceURI.
126127
*/
127-
def createElement(tagName: String): Element = js.native
128+
def createElement(tagName: String, options: String | ElementCreationOptions = js.native): Element = js.native
128129

129130
/** Creates an element with the specified namespace URI and qualified name. */
130-
def createElementNS(namespaceURI: String, qualifiedName: String): Element = js.native
131+
def createElementNS(namespaceURI: String, qualifiedName: String,
132+
options: String | ElementCreationOptions = js.native): Element = js.native
131133

132134
/** createAttribute creates a new attribute node, and returns it. */
133135
def createAttribute(name: String): Attr = js.native
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
trait ElementCreationOptions extends js.Object {
6+
var is: js.UndefOr[String] = js.undefined
7+
}

0 commit comments

Comments
 (0)