Skip to content

Commit 9499971

Browse files
author
Li Haoyi
committed
convert more functions, collapse telescoped constructors and methods to use the new default arguments
1 parent 7e70412 commit 9499971

File tree

5 files changed

+131
-440
lines changed

5 files changed

+131
-440
lines changed

src/main/scala/org/scalajs/dom/Css.scala

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,7 @@ class CSSStyleDeclaration extends js.Object {
186186
@scala.scalajs.js.annotation.JSBracketAccess
187187
def update(index: js.Number, v: js.String): Unit = ???
188188

189-
def setProperty(propertyName: js.String, value: js.String, priority: js.String): Unit = ???
190-
191-
def setProperty(propertyName: js.String, value: js.String): Unit = ???
189+
def setProperty(propertyName: js.String, value: js.String, priority: js.String = ???): Unit = ???
192190

193191
var animationFillMode: js.String = _
194192
var floodColor: js.String = _
@@ -335,40 +333,28 @@ class CSSStyleSheet extends StyleSheet {
335333
var cssRules: CSSRuleList = _
336334
var id: js.String = _
337335

338-
def addImport(bstrURL: js.String, lIndex: js.Number): js.Number = ???
339-
340-
def addImport(bstrURL: js.String): js.Number = ???
341-
342-
def addPageRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number): js.Number = ???
343-
344-
def addPageRule(bstrSelector: js.String, bstrStyle: js.String): js.Number = ???
345-
346-
def insertRule(rule: js.String, index: js.Number): js.Number = ???
336+
def addImport(bstrURL: js.String, lIndex: js.Number = ???): js.Number = ???
347337

338+
def addPageRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number = ???): js.Number = ???
348339
/**
349340
* The CSSStyleSheet.insertRule() method inserts a new style rule into the current
350341
* style sheet.
351342
*
352343
* MDN
353344
*/
354-
def insertRule(rule: js.String): js.Number = ???
345+
def insertRule(rule: js.String, index: js.Number = ???): js.Number = ???
355346

356-
def removeRule(lIndex: js.Number): Unit = ???
357-
358-
def deleteRule(index: js.Number): Unit = ???
359347

348+
def removeRule(lIndex: js.Number): Unit = ???
360349
/**
361350
* Deletes a rule from the style sheet.
362351
*
363352
* MDN
364353
*/
365-
def deleteRule(): Unit = ???
354+
def deleteRule(index: js.Number = ???): Unit = ???
366355

367-
def addRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number): js.Number = ???
368356

369-
def addRule(bstrSelector: js.String, bstrStyle: js.String): js.Number = ???
370-
371-
def addRule(bstrSelector: js.String): js.Number = ???
357+
def addRule(bstrSelector: js.String, bstrStyle: js.String = ???, lIndex: js.Number = ???): js.Number = ???
372358

373359
def removeImport(lIndex: js.Number): Unit = ???
374360
}
@@ -406,13 +392,10 @@ class CSSMediaRule extends CSSRule {
406392
var media: MediaList = _
407393
var cssRules: CSSRuleList = _
408394

409-
def insertRule(rule: js.String, index: js.Number): js.Number = ???
410-
411-
def insertRule(rule: js.String): js.Number = ???
395+
def insertRule(rule: js.String, index: js.Number = ???): js.Number = ???
412396

413-
def deleteRule(index: js.Number): Unit = ???
414397

415-
def deleteRule(): Unit = ???
398+
def deleteRule(index: js.Number = ???): Unit = ???
416399
}
417400

418401
/**

src/main/scala/org/scalajs/dom/Html.scala

Lines changed: 25 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -138,17 +138,14 @@ class HTMLTableElement extends HTMLElement {
138138
* MDN
139139
*/
140140
var border: js.String = ???
141-
142-
def deleteRow(index: js.Number): Unit = ???
143-
144141
/**
145142
* Removes the row corresponding to the index given in parameter. If the index value is
146143
* -1 the last row is removed; if it smaller than -1 or greater than the amount of rows in
147144
* the collection, a DOMException with the value IndexSizeError is raised.
148145
*
149146
* MDN
150147
*/
151-
def deleteRow(): Unit = ???
148+
def deleteRow(index: js.Number = ???): Unit = ???
152149

153150
def createTBody(): HTMLElement = ???
154151

@@ -158,9 +155,6 @@ class HTMLTableElement extends HTMLElement {
158155
* MDN
159156
*/
160157
def deleteCaption(): Unit = ???
161-
162-
def insertRow(index: js.Number): HTMLElement = ???
163-
164158
/**
165159
* Returns an HTMLElement representing a new row of the table. It inserts it in the rows
166160
* collection immediately before the <tr> element at the givent index position. If
@@ -170,7 +164,9 @@ class HTMLTableElement extends HTMLElement {
170164
*
171165
* MDN
172166
*/
173-
def insertRow(): HTMLElement = ???
167+
def insertRow(index: js.Number = ???): HTMLElement = ???
168+
169+
174170

175171
/**
176172
* Removes the first <tfoot> that is a child of the element.
@@ -205,11 +201,7 @@ class HTMLTableElement extends HTMLElement {
205201
*/
206202
def createCaption(): HTMLElement = ???
207203

208-
def moveRow(indexFrom: js.Number, indexTo: js.Number): Object = ???
209-
210-
def moveRow(indexFrom: js.Number): Object = ???
211-
212-
def moveRow(): Object = ???
204+
def moveRow(indexFrom: js.Number = ???, indexTo: js.Number = ???): Object = ???
213205

214206
/**
215207
* Returns an HTMLElement representing the first <tfoot> that is a child of the
@@ -282,13 +274,9 @@ class HTMLParagraphElement extends HTMLElement {
282274

283275

284276
trait HTMLAreasCollection extends HTMLCollection {
285-
def remove(index: js.Number): Unit = ???
286-
287-
def remove(): Unit = ???
288-
289-
def add(element: HTMLElement, before: js.Any): Unit = ???
277+
def remove(index: js.Number = ???): Unit = ???
290278

291-
def add(element: HTMLElement): Unit = ???
279+
def add(element: HTMLElement, before: js.Any = ???): Unit = ???
292280
}
293281

294282
class HTMLAppletElement extends HTMLElement {
@@ -393,31 +381,21 @@ class HTMLSelectElement extends HTMLElement {
393381
*/
394382
var multiple: js.Boolean = ???
395383
var `type`: js.String = ???
396-
397-
def remove(index: js.Number): Unit = ???
398-
399384
/**
400385
* Removes the element at the specified index from the options collection for this
401386
* select element.
402387
*
403388
* MDN
404389
*/
405-
def remove(): Unit = ???
406-
407-
def add(element: HTMLElement, before: js.Any): Unit = ???
408-
390+
def remove(index: js.Number = ???): Unit = ???
409391
/**
410392
* Adds an element to the collection of option elements for this select element.
411393
*
412394
* MDN
413395
*/
414-
def add(element: HTMLElement): Unit = ???
415-
416-
def item(name: js.Any, index: js.Any): js.Dynamic = ???
396+
def add(element: HTMLElement, before: js.Any = ???): Unit = ???
417397

418-
def item(name: js.Any): js.Dynamic = ???
419-
420-
def item(): js.Dynamic = ???
398+
def item(name: js.Any = ???, index: js.Any = ???): js.Dynamic = ???
421399

422400
def namedItem(name: js.String): js.Dynamic = ???
423401

@@ -696,18 +674,14 @@ class HTMLCollection extends js.Object {
696674
* MDN
697675
*/
698676
var length: js.Number = ???
699-
700-
def item(nameOrIndex: js.Any, optionalIndex: js.Any): Element = ???
701-
702-
def item(nameOrIndex: js.Any): Element = ???
703-
704677
/**
705678
* Returns the specific node at the given zero-based index into the list. Returns null
706679
* if the index is out of range.
707680
*
708681
* MDN
709682
*/
710-
def item(): Element = ???
683+
def item(nameOrIndex: js.Any = ???, optionalIndex: js.Any = ???): Element = ???
684+
711685

712686
/**
713687
* Returns the specific node whose ID or, as a fallback, name matches the string
@@ -822,9 +796,6 @@ class HTMLImageElement extends HTMLElement {
822796

823797
def create(): HTMLImageElement = ???
824798

825-
var msPlayToPrimary: js.Boolean = ???
826-
var msPlayToDisabled: js.Boolean = ???
827-
var msPlayToSource: js.Any = ???
828799
}
829800

830801
/**
@@ -1154,20 +1125,14 @@ class HTMLTableRowElement extends HTMLElement with HTMLTableAlignment {
11541125
var borderColor: js.Any = ???
11551126
var height: js.Any = ???
11561127
var borderColorDark: js.Any = ???
1157-
1158-
def deleteCell(index: js.Number): Unit = ???
1159-
11601128
/**
11611129
* Removes the cell at the given position in the row. If the given position is greater
11621130
* (or equal as it starts at zero) than the amount of cells in the row, or is smaller than
11631131
* 0, it raises a DOMException with the IndexSizeError value.
11641132
*
11651133
* MDN
11661134
*/
1167-
def deleteCell(): Unit = ???
1168-
1169-
def insertCell(index: js.Number): HTMLElement = ???
1170-
1135+
def deleteCell(index: js.Number = ???): Unit = ???
11711136
/**
11721137
* Inserts a new cell just before the given position in the row. If the given position is
11731138
* not given or is -1, it appends the cell to the row. If the given position is greater (or
@@ -1176,7 +1141,7 @@ class HTMLTableRowElement extends HTMLElement with HTMLTableAlignment {
11761141
*
11771142
* MDN
11781143
*/
1179-
def insertCell(): HTMLElement = ???
1144+
def insertCell(index: js.Number = ???): HTMLElement = ???
11801145
}
11811146

11821147
/**
@@ -1543,27 +1508,20 @@ class HTMLTableSectionElement extends HTMLElement with HTMLTableAlignment {
15431508
* MDN
15441509
*/
15451510
var rows: HTMLCollection = ???
1546-
1547-
def deleteRow(index: js.Number): Unit = ???
1548-
15491511
/**
15501512
* Removes the cell at the given position in the section. If the given position is
15511513
* greater (or equal as it starts at zero) than the amount of rows in the section, or is
15521514
* smaller than 0, it raises a DOMException with the IndexSizeError value.
15531515
*
15541516
* MDN
15551517
*/
1556-
def deleteRow(): Unit = ???
1557-
1558-
def moveRow(indexFrom: js.Number, indexTo: js.Number): Object = ???
1518+
def deleteRow(index: js.Number = ???): Unit = ???
15591519

1560-
def moveRow(indexFrom: js.Number): Object = ???
1520+
def moveRow(indexFrom: js.Number = ???, indexTo: js.Number = ???): Object = ???
15611521

1562-
def moveRow(): Object = ???
15631522

1564-
def insertRow(index: js.Number): HTMLElement = ???
1523+
def insertRow(index: js.Number = ???): HTMLElement = ???
15651524

1566-
def insertRow(): HTMLElement = ???
15671525
}
15681526

15691527
/**
@@ -1899,9 +1857,6 @@ class HTMLInputElement extends HTMLElement {
18991857
* MDN
19001858
*/
19011859
def checkValidity(): js.Boolean = ???
1902-
1903-
def stepDown(n: js.Number): Unit = ???
1904-
19051860
/**
19061861
* Decrements the value by (step * n), where n defaults to 1 if not specified. Throws an
19071862
* INVALID_STATE_ERR exception: if the method is not applicable to for the current
@@ -1910,9 +1865,7 @@ class HTMLInputElement extends HTMLElement {
19101865
*
19111866
* MDN
19121867
*/
1913-
def stepDown(): Unit = ???
1914-
1915-
def stepUp(n: js.Number): Unit = ???
1868+
def stepDown(n: js.Number = ???): Unit = ???
19161869

19171870
/**
19181871
* Increments the value by (step * n), where n defaults to 1 if not specified. Throws an
@@ -1922,7 +1875,7 @@ class HTMLInputElement extends HTMLElement {
19221875
*
19231876
* MDN
19241877
*/
1925-
def stepUp(): Unit = ???
1878+
def stepUp(n: js.Number = ???): Unit = ???
19261879

19271880
/**
19281881
* Sets a custom validity message for the element. If this message is not the empty
@@ -3156,15 +3109,11 @@ class HTMLElement extends Element {
31563109

31573110
def dragDrop(): js.Boolean = ???
31583111

3159-
def scrollIntoView(top: js.Boolean): Unit = ???
3160-
3161-
def scrollIntoView(): Unit = ???
3112+
def scrollIntoView(top: js.Boolean = ???): Unit = ???
31623113

31633114
def addFilter(filter: Object): Unit = ???
31643115

3165-
def setCapture(containerCapture: js.Boolean): Unit = ???
3166-
3167-
def setCapture(): Unit = ???
3116+
def setCapture(containerCapture: js.Boolean = ???): Unit = ???
31683117

31693118
/**
31703119
* Sets focus on the specified element, if it can be focused.
@@ -3207,19 +3156,13 @@ class HTMLElement extends Element {
32073156

32083157
def insertAdjacentElement(position: js.String, insertedElement: Element): Element = ???
32093158

3210-
def mergeAttributes(source: HTMLElement, preserveIdentity: js.Boolean): Unit = ???
3211-
3212-
def mergeAttributes(source: HTMLElement): Unit = ???
3159+
def mergeAttributes(source: HTMLElement, preserveIdentity: js.Boolean = ???): Unit = ???
32133160

32143161
def replaceAdjacentText(where: js.String, newText: js.String): js.String = ???
32153162

3216-
def applyElement(apply: Element, where: js.String): Element = ???
3217-
3218-
def applyElement(apply: Element): Element = ???
3163+
def applyElement(apply: Element, where: js.String = ???): Element = ???
32193164

3220-
def addBehavior(bstrUrl: js.String, factory: js.Any): js.Number = ???
3221-
3222-
def addBehavior(bstrUrl: js.String): js.Number = ???
3165+
def addBehavior(bstrUrl: js.String, factory: js.Any = ???): js.Number = ???
32233166

32243167
def insertAdjacentHTML(where: js.String, html: js.String): Unit = ???
32253168

@@ -3740,19 +3683,14 @@ class HTMLFormElement extends HTMLElement {
37403683
* MDN
37413684
*/
37423685
def reset(): Unit = ???
3743-
3744-
def item(name: js.Any, index: js.Any): js.Dynamic = ???
3745-
3746-
def item(name: js.Any): js.Dynamic = ???
3747-
37483686
/**
37493687
* Gets the item in the elements collection at the specified index, or null if there is
37503688
* no item at that index. You can also specify the index in array-style brackets or
37513689
* parentheses after the form object name, without calling this method explicitly.
37523690
*
37533691
* MDN
37543692
*/
3755-
def item(): js.Dynamic = ???
3693+
def item(name: js.Any = ???, index: js.Any = ???): js.Dynamic = ???
37563694

37573695
/**
37583696
* This method does something similar to activating a submit button of the form.

0 commit comments

Comments
 (0)