Skip to content

Commit 116cc24

Browse files
authored
Merge pull request #491 from scala-js/issue/488
Fix #488 `HTMLMediaElement.play()` should return `Promise`
2 parents e0bf009 + 73cab73 commit 116cc24

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

api-reports/2_12.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4437,7 +4437,7 @@ raw/HTMLAudioElement[JC] var parentElement: HTMLElement
44374437
raw/HTMLAudioElement[JC] def parentNode: Node
44384438
raw/HTMLAudioElement[JC] def pause(): Unit
44394439
raw/HTMLAudioElement[JC] def paused: Boolean
4440-
raw/HTMLAudioElement[JC] def play(): Unit
4440+
raw/HTMLAudioElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
44414441
raw/HTMLAudioElement[JC] var playbackRate: Double
44424442
raw/HTMLAudioElement[JC] def played: TimeRanges
44434443
raw/HTMLAudioElement[JC] def prefix: String
@@ -9538,7 +9538,7 @@ raw/HTMLMediaElement[JC] var parentElement: HTMLElement
95389538
raw/HTMLMediaElement[JC] def parentNode: Node
95399539
raw/HTMLMediaElement[JC] def pause(): Unit
95409540
raw/HTMLMediaElement[JC] def paused: Boolean
9541-
raw/HTMLMediaElement[JC] def play(): Unit
9541+
raw/HTMLMediaElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
95429542
raw/HTMLMediaElement[JC] var playbackRate: Double
95439543
raw/HTMLMediaElement[JC] def played: TimeRanges
95449544
raw/HTMLMediaElement[JC] def prefix: String
@@ -15205,7 +15205,7 @@ raw/HTMLVideoElement[JC] var parentElement: HTMLElement
1520515205
raw/HTMLVideoElement[JC] def parentNode: Node
1520615206
raw/HTMLVideoElement[JC] def pause(): Unit
1520715207
raw/HTMLVideoElement[JC] def paused: Boolean
15208-
raw/HTMLVideoElement[JC] def play(): Unit
15208+
raw/HTMLVideoElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
1520915209
raw/HTMLVideoElement[JC] var playbackRate: Double
1521015210
raw/HTMLVideoElement[JC] def played: TimeRanges
1521115211
raw/HTMLVideoElement[JC] var poster: String

api-reports/2_13.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4437,7 +4437,7 @@ raw/HTMLAudioElement[JC] var parentElement: HTMLElement
44374437
raw/HTMLAudioElement[JC] def parentNode: Node
44384438
raw/HTMLAudioElement[JC] def pause(): Unit
44394439
raw/HTMLAudioElement[JC] def paused: Boolean
4440-
raw/HTMLAudioElement[JC] def play(): Unit
4440+
raw/HTMLAudioElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
44414441
raw/HTMLAudioElement[JC] var playbackRate: Double
44424442
raw/HTMLAudioElement[JC] def played: TimeRanges
44434443
raw/HTMLAudioElement[JC] def prefix: String
@@ -9538,7 +9538,7 @@ raw/HTMLMediaElement[JC] var parentElement: HTMLElement
95389538
raw/HTMLMediaElement[JC] def parentNode: Node
95399539
raw/HTMLMediaElement[JC] def pause(): Unit
95409540
raw/HTMLMediaElement[JC] def paused: Boolean
9541-
raw/HTMLMediaElement[JC] def play(): Unit
9541+
raw/HTMLMediaElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
95429542
raw/HTMLMediaElement[JC] var playbackRate: Double
95439543
raw/HTMLMediaElement[JC] def played: TimeRanges
95449544
raw/HTMLMediaElement[JC] def prefix: String
@@ -15205,7 +15205,7 @@ raw/HTMLVideoElement[JC] var parentElement: HTMLElement
1520515205
raw/HTMLVideoElement[JC] def parentNode: Node
1520615206
raw/HTMLVideoElement[JC] def pause(): Unit
1520715207
raw/HTMLVideoElement[JC] def paused: Boolean
15208-
raw/HTMLVideoElement[JC] def play(): Unit
15208+
raw/HTMLVideoElement[JC] def play(): js.UndefOr[js.Promise[Unit]]
1520915209
raw/HTMLVideoElement[JC] var playbackRate: Double
1521015210
raw/HTMLVideoElement[JC] def played: TimeRanges
1521115211
raw/HTMLVideoElement[JC] var poster: String

src/main/scala/org/scalajs/dom/raw/Html.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3164,7 +3164,7 @@ abstract class HTMLMediaElement extends HTMLElement {
31643164
*
31653165
* MDN
31663166
*/
3167-
def play(): Unit = js.native
3167+
def play(): js.UndefOr[js.Promise[Unit]] = js.native
31683168

31693169
/**
31703170
* Begins loading the media content from the server.

0 commit comments

Comments
 (0)